Repository navigation
CIRC-2697 Add request queue locking - #1702
Open
alexanderkurash wants to merge 3 commits into
Open
alexanderkurash wants to merge 3 commits into
alexanderkurash wants to merge 3 commits into
Conversation
|
roman-barannyk
approved these changes
Oct 16, 2026
|
|
||
| boolean allCreatorsReady = ready.await(5, TimeUnit.SECONDS); | ||
| start.countDown(); | ||
| Assertions.assertTrue(allCreatorsReady); |
OleksandrVidinieiev
approved these changes
Oct 16, 2026
| RequestQueueKey key = RequestQueueKey.from(records); | ||
| String message = "Request queue positions are not sequential for " | ||
| + key.queueType() + ":" + key.queueId(); | ||
| log.error(message); |
Contributor
There was a problem hiding this comment.
Add method name to log message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Prevent race conditions when concurrent operations recalculate positions in the same request queue.
Previously, simultaneous request creation or other queue-changing operations could read the same queue state and persist duplicate or inconsistent positions.
https://folio-org.atlassian.net/browse/CIRC-2697
Approach
request-queue-lock-storageinterface.mod-settings.503 Service Unavailableresponse when lock acquisition times out.This change requires the corresponding
request-queue-lock-storageimplementation from CIRCSTORE-684.TODOS and Open Questions