Repository navigation
CIRC-2685 Accept and persist inHouseUse in check-in-by-barcode - #1703
Merged
Merged
Conversation
roman-barannyk
requested review from
OleksandrVidinieiev,
alexanderkurash,
kjain110 and
mukhiddin-yusuf
October 15, 2026 12:00
|
OleksandrVidinieiev
approved these changes
Oct 16, 2026
alexanderkurash
approved these changes
Oct 16, 2026
mukhiddin-yusuf
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The POST /circulation/check-in-by-barcode endpoint currently detects in-house use automatically based on item state (item is available, no pending requests, service point serves the item's home location — LoanCheckInService.isInHouseUse()). The result is returned in the response but never persisted to the check-in record in storage.
This story makes two related changes: it accepts an explicit inHouseUse boolean from the caller, allowing staff intent to override the inference logic; and it persists the final in-house-use decision — whether derived from the new parameter or from the existing fallback — to the inHouseUse field of the check-in record in mod-circulation-storage.
Approach
The resolution precedence is: explicit true from the request → skip inference and use true; otherwise → run existing LoanCheckInService.isInHouseUse() as the fallback. The resolved value flows through CheckInContext.inHouseUse (already present) into CheckInRecord.toJson(), which is the serialization point that CheckInStorageRepository sends to storage.
Resolves: CIRC-2685