Repository navigation
MODEUS-244: Set the harvesting status of UDPs with service type cs41 to inactive on upgrade - #238
Merged
charismatic-claire merged 5 commits intoOct 13, 2026
Conversation
alb3rtino
self-requested a review
October 6, 2026 09:14
alb3rtino
reviewed
Oct 6, 2026
…to inactive on upgrade * Add migration script * Register migration script * Update sample data for tests * Add news
…to inactive on upgrade Update "UsageDataProvidersIT" to JUnit5, since we don't want to add new tests to outdated test frameworks.
…to inactive on upgrade Adding integration test for the newly added data migration script when updating from 5.2.0 to 5.3.0.
charismatic-claire
force-pushed
the
MODEUS-244-set-harvesting-status-to-inactive
branch
from
October 12, 2026 14:28
e5b0dfb to
450f255
Compare
charismatic-claire
force-pushed
the
MODEUS-244-set-harvesting-status-to-inactive
branch
from
October 12, 2026 14:36
450f255 to
e73645a
Compare
alb3rtino
requested changes
Oct 12, 2026
alb3rtino
reviewed
Oct 12, 2026
* Remove obsolete test from UsageDataProvidersIT * Rename MigrateRemoveAggregatorIT * Add tests there instead of UsageDataProvidersIT * Remove obsolete fields from SAMPLE_R4.json * Revert .gitignore update
|
charismatic-claire
deleted the
MODEUS-244-set-harvesting-status-to-inactive
branch
October 13, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODEUS-244](https://folio-org.atlassian.net/browse/MODEUS-244
Purpose
The harvester no longer supports COUNTER 4.1 SUSHI (service type
cs41). Usage data providersconfigured with
cs41and an active harvesting status would keep being picked up for harvesting,and those runs can only fail. This PR sets their harvesting status to
inactivewhen a tenant isupgraded, so they are no longer harvested. Their configuration and existing reports are kept.
Approach
migration/5.3.0/migrate_cs41_harvesting_status.sqland register it inschema.json(fromModuleVersion: mod-erm-usage-5.3.0,run: after). It setsharvestingConfig.harvestingStatustoinactivefor all UDPs whoseharvestingConfig.sushiConfig.serviceTypeiscs41. UDPs that are already inactive are skipped,and no other field changes.
SAMPLE_R4.json(service typecs41) toharvestingStatus: inactive, so afresh install with
loadSample=truematches the state after an upgrade.MigrateRemoveAggregatorITto JUnit5 and rename it toMigrateRemoveAggregatorAndCS41HarvestingStatusITUsageDataProvidersITfrom JUnit 4 to JUnit 5 (impl2→impl3) instead of adding anew test to the outdated framework, and register it in
ITSuite. It now uses the sharedPostgres container, verticle and
@SetupTenant.ITSuite.dependency-reduced-pom.xmlto the Maven section