Repository navigation
Conversation
zburke
marked this pull request as ready for review
October 5, 2026 19:03
JohnC-80
approved these changes
Oct 6, 2026
|
Member
Author
|
@JohnC-80, I re-requested a review because two important changes were not yet in place when I asked you to look at this earlier (sorry):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
@folio/stripes-webpackfrom v7 to v8 (v8 no longer relies onbabel-loader)babelOptionsfrom@folio/stripes-webpackwas re-exported)babel-plugin-istanbulwithistanbul-lib-instrument@folio/stripes-testingdependency (nothing has relied on it since the NightmareJS tests were purged from platform-complete years ago and it's hard to believe we didn't think of doing this sooner)Motivation
@folio/stripes-webpacktransitively, typically via this package. Thus, the way to supply the updated version of stripes-webpack is to update it here in stripes-cli. The changes here (removingbabel-loader[by updating stripes-webpack] and@folio/stripes-testing) allow dependent libraries to substantially clean up their own dependency hierarchy by removing these two very old dependencies.babelOptionswas re-exported back in the BTOG days. Withoutbabel-loader, we no longer have or needbabelOptions.Refs STCLI-292