Skip to content

UIEUS-564: Drop harvestVia seeding, require usage-data-providers 4.0 and erm-usage-harvester 3.0 - #655

Merged
elsenhans merged 3 commits into
masterfrom
UIEUS-564-drop-harvestVia
Oct 12, 2026
Merged

elsenhans merged 3 commits into
masterfrom
UIEUS-564-drop-harvestVia

Conversation

@elsenhans

@elsenhans elsenhans commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

UIEUS-564

Follow-up to https://folio-org.atlassian.net/browse/UIEUS-562 once mod-erm-usage and mod-erm-usage-harvester are released without the aggregator fields: ui-erm-usage stops writing harvestingConfig.harvestVia and requires the new interface versions. Blocked until both backend releases exist.

Approach

  • Remove withHarvestVia (util, test, calls in UDPCreateRoute and UDPEditRoute) and the constant HARVEST_VIA_SUSHI
  • The UI no longer writes harvestingConfig.harvestVia
  • Remove ?aggregator=false from all erm-usage-harvester/impl requests
  • Require usage-data-providers 4.0 and erm-usage-harvester 3.0
  • Remove harvestVia from the test fixtures
  • UDPEditRoute save test (no longer expects harvestVia)

Dependencies

@elsenhans
elsenhans requested a review from a team as a code owner October 9, 2026 08:29
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Jest Unit Test Results

260 tests   - 3   260 ✅  - 3   2m 42s ⏱️ +31s
 41 suites  - 1     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a9b085b. ± Comparison against base commit 1ab7de3.

This pull request removes 4 and adds 1 tests. Note that renamed tests count towards both.
UDPEditRoute saves the UDP with harvestVia sushi ‑ UDPEditRoute saves the UDP with harvestVia sushi
withHarvestVia adds harvestVia sushi to a UDP without harvestVia ‑ withHarvestVia adds harvestVia sushi to a UDP without harvestVia
withHarvestVia adds harvestingConfig if missing ‑ withHarvestVia adds harvestingConfig if missing
withHarvestVia replaces another harvestVia with sushi ‑ withHarvestVia replaces another harvestVia with sushi
UDPEditRoute saves the UDP ‑ UDPEditRoute saves the UDP

♻️ This comment has been updated with latest results.

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@elsenhans
elsenhans merged commit 786beba into master Oct 12, 2026
25 checks passed
@elsenhans
elsenhans deleted the UIEUS-564-drop-harvestVia branch October 12, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants