Repository navigation
Spec: lock the current font list of source.yml - #286
Merged
ronaldtse merged 4 commits intoNov 13, 2026
Merged
Conversation
Contributor
|
The spec is correct and this failure is real, but not the spec's fault: the v1.4 archive inherits a defect from the Pal3love 2.005 conversion — the ExtraLight TTC's Hong Kong face is misnamed |
ronaldtse
added a commit
that referenced
this pull request
Nov 13, 2026
Extends the source.yml regression lock (#286) to the Latin families the fleet stylesheets hardcode: Source Sans Pro / Source Serif Pro / Source Code Pro must exist with their full name sets (base + weight variants; Sans/Serif Pro ship no Medium cut), Regular/Bold/Italic/ Bold Italic styles on each base family, and Regular+Italic on each weight variant. styles_of now also covers standalone fonts entries, not just font_collections.
ronaldtse
deleted the
lane/13-01-spec-lock-the-current-font-list-of-sourc
branch
November 14, 2026 01:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: lock the current font list of source.yml
Part of #284: source.yml (Source Han Sans): fetches stale source-fonts v1.0 — update to the correct current location
Problem
Nothing checks what Formulas/source.yml provides, so re-pointing it to a new archive could silently drop names like 'Source Han Sans' Regular/Bold that the Manifest lookups depend on.
Fix
Done when
check.rb:
Warning! PATH is not properly set up, /Users/umerhassan/.rvm/gems/ruby-3.4.8/bin is not at first place.
Usually this is caused by shell initialization files. Search for
PATH=...entries.You can also re-add RVM to your profile by running:
rvm get stable --auto-dotfilesTo fix it temporarily in this shell session run:
rvm use ruby-3.4.8To ignore this error add
rvm_silence_path_mismatch_check_flag=1to your~/.rvmrcfile.specs: SKIP (no lib or spec changes)
rubocop: SKIP (no ruby changes)