Skip to content

Spec: lock the current font list of source.yml - #286

Merged
ronaldtse merged 4 commits into
v5from
lane/13-01-spec-lock-the-current-font-list-of-sourc
Nov 13, 2026
Merged

ronaldtse merged 4 commits into
v5from
lane/13-01-spec-lock-the-current-font-list-of-sourc

Conversation

@HassanAkbar

Copy link
Copy Markdown
Member

Spec: lock the current font list of source.yml

Part of #284: source.yml (Source Han Sans): fetches stale source-fonts v1.0 — update to the correct current location

Problem

Nothing checks what Formulas/source.yml provides, so re-pointing it to a new archive could silently drop names like 'Source Han Sans' Regular/Bold that the Manifest lookups depend on.

Fix

  • Add a spec that loads Formulas/source.yml and asserts: the Source Han Sans font names (base, HC, K, SC, TC and the ExtraLight/Light/Normal/Medium/Heavy variants) appear in font_collections with their current styles; every style has post_script_name and version; every fonts entry has a font file; the resource has urls, sha256 and file_size.

Done when

  • The new spec passes on current origin/v4
  • The existing spec/ suite stays green

check.rb:
Warning! PATH is not properly set up, /Users/umerhassan/.rvm/gems/ruby-3.4.8/bin is not at first place.
Usually this is caused by shell initialization files. Search for PATH=... entries.
You can also re-add RVM to your profile by running: rvm get stable --auto-dotfiles
To fix it temporarily in this shell session run: rvm use ruby-3.4.8
To ignore this error add rvm_silence_path_mismatch_check_flag=1 to your ~/.rvmrc file.
specs: SKIP (no lib or spec changes)
rubocop: SKIP (no ruby changes)

@ronaldtse

Copy link
Copy Markdown
Contributor

The spec is correct and this failure is real, but not the spec's fault: the v1.4 archive inherits a defect from the Pal3love 2.005 conversion — the ExtraLight TTC's Hong Kong face is misnamed SourceHanSansHC (concatenated, no weight), so Source Han Sans HC ExtraLight, present in every release since v1.0, is missing from the formula. The repair is in flight at fontist/source-fonts#5 (build-time name repair + a publication-gate rule rejecting any non-canonical family name). Once a v1.5 archive is published and the formula is re-pointed at it, this spec passes as written — keeping the strict 30-name lock exactly as authored.

@ronaldtse
ronaldtse merged commit ac3e6f2 into v5 Nov 13, 2026
7 checks passed
ronaldtse added a commit that referenced this pull request Nov 13, 2026
Extends the source.yml regression lock (#286) to the Latin families the
fleet stylesheets hardcode: Source Sans Pro / Source Serif Pro /
Source Code Pro must exist with their full name sets (base + weight
variants; Sans/Serif Pro ship no Medium cut), Regular/Bold/Italic/
Bold Italic styles on each base family, and Regular+Italic on each
weight variant. styles_of now also covers standalone fonts entries,
not just font_collections.
@ronaldtse
ronaldtse deleted the lane/13-01-spec-lock-the-current-font-list-of-sourc branch November 14, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants