Use current Foobara version in generated gemspec - #7
Conversation
|
Maybe we could do a bit of refactoring and put this |
Yeah that could be good to relocate it. If wanting to clean it up a bit you could move it to a method in https://github.com/foobara/empty-ruby-project-generator/blob/main/src/generators/gemspec_generator.rb Maybe something like |
|
sure thing. gonna proceed with that |
|
LGTM! Though there's interestingly a merge conflict |
|
gonna take a look and find out why |
…rsion-of-foobara to resolve merge conflicts
|
done fixing the conflict |
| gemspec_path = result.keys.find { |path| path.end_with?(".gemspec") } | ||
|
|
||
| expect(result.fetch(gemspec_path)).to include(">= #{current_version}") | ||
| end |
There was a problem hiding this comment.
I'm still a bit skeptical about this test but mostly harmless I think so I'll merge it
There was a problem hiding this comment.
I could submit another PR to improve it. Though I'm curious what the improvement could be. maybe an idea i have is that the test is currently testing for just this part ">= #{current_foobara_version}". Maybe it could be improved to test this entire line ">= #{current_foobara_version}", "<2.0.0". Though i wonder if that would make the test a bit more rigid because what it we go past the 2.0.0 version in the future?
|
Thanks!! |
2 participants
Fixes #2