Skip to content

Parse NOTICE.xml with lxml XML parser #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soimkim merged 3 commits into from
Jul 31, 2026
Merged

Parse NOTICE.xml with lxml XML parser #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e39833
fix(android): parse repo manifest.xml with lxml XML parser
soimkim Jul 31, 2026
220b945
fix(android): parse NOTICE.xml with lxml XML parser
soimkim Jul 31, 2026
ef36f58
chore(android): demote binary match POST failure logs to debug
soimkim Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/fosslight_android/_binary_db_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,13 +166,13 @@ def _post_binary_match(kb_url: str, kb_token: str, items: list) -> PostMatchResu
except Exception:
pass
# Host responded → reachable; caller may continue with next chunks
logger.warning(
logger.debug(
f"KB({kb_url}) reachable but binary match HTTP {ex.code}: {body or ex.reason}"
)
return None, False
except urllib.error.URLError as ex:
logger.warning(f"KB({kb_url}) Unreachable: {ex.reason if hasattr(ex, 'reason') else ex}")
logger.debug(f"KB({kb_url}) Unreachable: {ex.reason if hasattr(ex, 'reason') else ex}")
return None, True
Comment thread
soimkim marked this conversation as resolved.
except Exception as ex:
logger.warning(f"KB({kb_url}) binary match failed: {ex}")
logger.debug(f"KB({kb_url}) binary match failed: {ex}")
return None, False
3 changes: 2 additions & 1 deletion src/fosslight_android/android_binary_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,8 @@ def get_repositories_name():
# Get repository name from manifest first.
read_success, manifest_content = read_file(".repo/manifest.xml", True)
if read_success:
soup = BeautifulSoup(manifest_content, "lxml")
# manifest.xml is XML — use lxml XML parser (not HTML "lxml")
soup = BeautifulSoup(manifest_content, "lxml-xml")
for remote_info in soup.findAll("remote"):
if str(remote_info['review']).find("android-review.googlesource.com") > -1: # Only in case of aosp
remote_is_aosp = True
Expand Down
3 changes: 2 additions & 1 deletion src/fosslight_android/check_notice_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ def read_notice_file(notice_file_path):

def parsing_notice_xml_format(notice_file_content):
file_list = {}
soup = BeautifulSoup(notice_file_content, "lxml")
# NOTICE.xml is XML — use lxml XML parser (not HTML "lxml")
soup = BeautifulSoup(notice_file_content, "lxml-xml")

for e in soup.findAll("file-name"): # NOTICE.xml
line = e.text.strip()
Expand Down
Loading