Skip to content

perf(binary): batch file type checks in find - #68

Merged
soimkim merged 1 commit into
mainfrom
perf/batch-file-find
Sep 29, 2026
Merged

soimkim merged 1 commit into
mainfrom
perf/batch-file-find

Conversation

@soimkim

@soimkim soimkim commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep the same find paths and filters in find_binaries_from_out_dir.
  • Run file on many paths per process (-exec file {} +) instead of one process per file.

Test plan

  • system/fonts, system/bin, and system/lib64 return the same paths as file {} \;.
  • root/ still does not apply the .odex exclusion used for system/.
  • Android 17 scan still skips a missing search directory instead of running find on it.

Run file on many paths per process so the same filters finish faster.
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: fosslight/fosslight_android_scanner/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: bcb3123c-77fc-4f80-9ac4-7a68386e9e62

📥 Commits

Reviewing files that changed from the base of the PR and between 0fb74a0 and 9e3200b.

📒 Files selected for processing (1)
  • src/fosslight_android/android_binary_analysis.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soimkim soimkim self-assigned this Sep 29, 2026
@soimkim soimkim added the enhancement New feature or request label Sep 29, 2026
@soimkim
soimkim merged commit 2088d29 into main Sep 29, 2026
6 of 7 checks passed
@soimkim
soimkim deleted the perf/batch-file-find branch September 29, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant