Skip to content

fix(licenses): remove license suffixes from replacement list - #323

Merged
soimkim merged 1 commit into
mainfrom
fix/orLater
Oct 1, 2026
Merged

soimkim merged 1 commit into
mainfrom
fix/orLater

Conversation

@JustinWonjaePark

@JustinWonjaePark JustinWonjaePark commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor
  • Chore
    • License detections now retain suffixes such as -only, -old-style, and -or-later, including in license lists and comments.
  • Documentation
    • Updated the README to reflect how license names appear in scanner output.

@JustinWonjaePark JustinWonjaePark self-assigned this Oct 1, 2026
@JustinWonjaePark JustinWonjaePark added the chore [PR/Issue] Refactoring, maintenance the code label Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: fosslight/fosslight_source_scanner/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2ac54d70-d9fb-47d1-94c7-762a3edc3ae0

📥 Commits

Reviewing files that changed from the base of the PR and between d4277be and d697c22.

📒 Files selected for processing (3)
  • README.md
  • src/fosslight_source/_scan_item.py
  • tests/test_parsing_unknown_spdx.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The scanner no longer removes -only, -old-style, or -or-later from license names. Tests now expect affected GPL detections to retain the -only suffix, and the README description reflects the change.

Changes

License suffix handling

Layer / File(s) Summary
Retain license suffixes
src/fosslight_source/_scan_item.py, tests/test_parsing_unknown_spdx.py, README.md
The scanner keeps license suffixes instead of removing them. Updated tests expect GPL-2.0-only in affected license lists and comments. The README no longer states that suffixes are removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: soimkim

Merge Risk: ⚪ Minimal · up to d697c

License detections retain their SPDX suffixes as intended, with updated tests and documentation. No actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing license suffixes from the replacement list. It is concise and specific.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Park Wonjae <wonjae.park@lge.com>
@JustinWonjaePark JustinWonjaePark changed the title fix(licenses): limit suffix preservation to replacement list fix(licenses): remove license suffixes from replacement list Oct 1, 2026
@JustinWonjaePark
JustinWonjaePark marked this pull request as ready for review October 1, 2026 04:43
@soimkim
soimkim merged commit 25f3225 into main Oct 1, 2026
8 checks passed
@soimkim
soimkim deleted the fix/orLater branch October 1, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants