Repository navigation
Conversation
Co-authored-by: mat <mat@foxglove.dev>
Co-authored-by: mat <mat@foxglove.dev>
…k, perf and resource leaks Co-authored-by: mat <mat@foxglove.dev>
…autocomplete Co-authored-by: mat <mat@foxglove.dev>
…llows pose Co-authored-by: mat <mat@foxglove.dev>
…anged Co-authored-by: mat <mat@foxglove.dev>
…ture behind flag Co-authored-by: mat <mat@foxglove.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype for VIZ-3444. It adds a Foxglove panel extension that draws a "ghost" of a 3D model at the time you hover on the timeline, even while playback is paused. The model at the current time is drawn alongside it, like the reference screenshot in the request.
Ghost preview
Why a custom panel
RenderState.previewTimegives the hovered seek-bar time, andsubscribeMessageRangegives every pose in the recording. Together they let the panel look up the pose at any hovered time.What's included (
extensions/model_ghost_preview/)extension/):foxglove.PoseInFrame,PosesInFrame,FrameTransform(s), ROSPoseStamped,Odometry,TFMessageandTransformStamped. TF-style topics pick a child frame, with autocomplete.+Δtlabel.demo/generate_demo_mcap.pyuses the Foxglove SDK to write a truck on a winding haul road (/truck/pose,/tf,/scene/road).foxglove_layouts/model_ghost_preview.json.extension/dev/): mounts the real panel with a mockPanelExtensionContextand a fake timeline. It was used to capture the README screenshots..utils/generate_readme.pyhas a new "Foxglove Extensions" category, and the rootREADME.mdis regenerated.How this was built
Grok implemented the plan, and Opus reviewed each round. There were five rounds, ending with Opus approving. Issues found and fixed along the way:
/tf.Testing
npm run lint,npx tsc --noEmit,npm test,npm run buildandnpm run packageall pass./truck/posemessages, 1200/tfand 1/scene/road.Model Ghost Preview.Model Ghost Preview) was worked out from the Studio extension loader code. The README explains how to add the panel by hand if the layout shows it as unknown.Known limitations
To show artifacts inline, enable in settings.