Repository navigation
Conversation
UPSTREAM and the upstream/ directory differ only by case, so a fresh clone on a case-insensitive filesystem (default macOS and Windows) cannot hold both: git reports UPSTREAM as deleted and build fails with IsADirectoryError. Rename the lock to UPSTREAM.lock (content unchanged) and update its readers. Add a test that fails when two tracked paths, including directory prefixes, differ only by case, and a macOS CI job that checks the checkout is complete. The macOS job also surfaced a temp-path comparison in test_runtime.py that failed on macOS before this change (/var is a symlink to /private/var); the test now resolves its temp root.
check-models read the catalog with a bare json.loads and indexed model["slug"], so a missing file, malformed JSON or an unexpected shape ended in a Python traceback. check-runtime already reports the same inputs as a BLOCKED diagnostic. catalog_models() now shape-checks every entry in file order (duplicates are kept, so a disabled or malformed earlier entry is still seen), catalog_efforts() projects reasoning efforts, and load_catalog() keeps its return shape. check-models reads the catalog once inside one error boundary and exits 1 with "cannot read model catalog <path>: <reason>".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1. This branch contains that PR's commit until it merges; the change for review here is the last commit,
fix: report unreadable model catalogs without a traceback. I'll rebase ontomainonce #1 lands.check-modelsends in a Python traceback when the catalog is missing or has an unexpected shape, for example:check-runtimealready turns the same inputs into aBLOCKEDdiagnostic, so this bringscheck-modelsin line:catalog_models()shape-checks every entry in file order (an object document, amodelsarray, object entries with string slugs). Duplicates are kept, so a disabled or malformed earlier entry for the same slug is still seen.catalog_efforts()is the existing effort projection;load_catalog()keeps its return shape, socheck-runtimebehaves exactly as before.check-modelsreads the catalog once inside one(OSError, ValueError)boundary and exits 1 withcannot read model catalog <path>: <reason>on stderr, before printing anything else. The disabled-model check reuses the validated entries instead of parsing the file a second time.Tests (
tests/test_runtime.py,CheckModelsCLI): eight error cases (missing file, malformed JSON, non-object document, non-arraymodels, non-object entry, missing slug, non-string slug, malformed effort) all fail onmainand pass here; a duplicate-slug regression; and a valid catalog that still resolves and clamps an effort, which passes before and after.Verified on a fresh macOS clone: 28 tests OK, build, license
cmp,git diff --checkand an unchangedupstream/. No live delegation is involved.