Repository navigation
docs(agents): reviewers name their catch; retro checks model - #44
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ADR-0042 harness.part-names-its-failure: a Catches line on every reviewer seat states the failure it exists for, so a review can ask whether the seat still catches it on the current model. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each sentence now names only failures its seat's own checklist covers; one blank line after it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ADR-0042: the weekly retro runs amont-agent harness-review --check and reports a model no review covers (exit 1 only; an older amont-agent adds nothing), and says when two model families are reviewed so the ADR's Revisit trigger can be checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
--check's stdout alone reaches the report; distinct model strings stand in for families under a holds-until; the weekly repeat is stated as intended. Fixture: two review files with different models print the Revisit line; the installed amont-agent without the command adds nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 (dotfiles half) of decisions
docs/plans/2026-10-21-harness-earns-its-place.md, implementing ADR-0042.plan-review-*,implementation-review,interface-review) start with aCatches:line naming the failure the seat exists for, worded to match only what its own checklist covers (harness.part-names-its-failure).amont-agent harness-review --checkand adds a Harness line on exit 1 only, so an amont-agent without the command (exit 2) adds nothing (harness.revisit-on-a-new-model). It also says when review files name two model families, the owner of ADR-0042's Revisit trigger; distinct model strings stand in for families under aholds-until:.Verification
grep -l '^Catches: 'over the reviewer filesbash -n,shellcheck -S warningImplementation review: approve after two deltas. Deferred to decisions: listing interface-review.md in the plan's Phase 3.
🤖 Generated with Claude Code