Repository navigation
docs(review): code rules in full for review - #46
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The implementation-review brief carries the code rules in full and the decisions for the changed files; the reviewer blocks on a code-rule violation the diff introduces, deletions included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the code-rules plan (canonical in aval:
docs/plans/2026-10-23-code-rules-reach-writers-reviewers.md; ADR in fredericrous/decisions#86).What changes
worktree-taskF4b: the implementation-review brief carries the code rules in full (aval --json rules --level constraint --governs code --full), the other constraints, and the decisions that apply to the changed files (aval relevant --json --top 20per changed file, never--changed; skipped on an empty diff; each key resolved).implementation-reviewagent: a code-rule violation the diff introduces, deletions included (old-sidefile:line), is a blocking finding with the rule id; pre-existing violations are out of scope; an applicable decision outranks a rule. The verdict paragraph says when that isrework(the fix changes the design) and when a blocking finding underapprove-with-changes(a local edit fixes it).Verification
Only this branch's hunks were patched into the live
~/.claude(the liveSKILL.mdcarries a newer preview step not onorigin/main, whichchezmoi applywould revert). The real reviewer, on briefs built by the new step against the relais branch:names.reveal-intentatrepo.rs:115-117;reliability.every-wait-is-boundedat the deleted line.Which agent text the drill subagent loaded is not provable mid-session; the next session's first review checks the new verdict wording.
Review
Implementation review: round 1 approve-with-changes, Delta approve.
🤖 Generated with Claude Code