Skip to content

docs(review): code rules in full for review - #46

Merged
fredericrous merged 5 commits into
mainfrom
docs/code-rules-full-text
Oct 24, 2026
Merged

fredericrous merged 5 commits into
mainfrom
docs/code-rules-full-text

Conversation

@fredericrous

Copy link
Copy Markdown
Owner

Phase 4 of the code-rules plan (canonical in aval: docs/plans/2026-10-23-code-rules-reach-writers-reviewers.md; ADR in fredericrous/decisions#86).

What changes

  • worktree-task F4b: the implementation-review brief carries the code rules in full (aval --json rules --level constraint --governs code --full), the other constraints, and the decisions that apply to the changed files (aval relevant --json --top 20 per changed file, never --changed; skipped on an empty diff; each key resolved).
  • implementation-review agent: a code-rule violation the diff introduces, deletions included (old-side file:line), is a blocking finding with the rule id; pre-existing violations are out of scope; an applicable decision outranks a rule. The verdict paragraph says when that is rework (the fix changes the design) and when a blocking finding under approve-with-changes (a local edit fixes it).

Verification

Only this branch's hunks were patched into the live ~/.claude (the live SKILL.md carries a newer preview step not on origin/main, which chezmoi apply would revert). The real reviewer, on briefs built by the new step against the relais branch:

  • seeded single-letter names → blocking finding citing names.reveal-intent at repo.rs:115-117;
  • seeded deletion of a subprocess timeout → blocking finding citing reliability.every-wait-is-bounded at the deleted line.
    Which agent text the drill subagent loaded is not provable mid-session; the next session's first review checks the new verdict wording.

Review

Implementation review: round 1 approve-with-changes, Delta approve.

🤖 Generated with Claude Code

fredericrous and others added 5 commits October 24, 2026 02:47
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The implementation-review brief carries the code rules in full and the
decisions for the changed files; the reviewer blocks on a code-rule
violation the diff introduces, deletions included.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fredericrous
fredericrous merged commit fa03cb0 into main Oct 24, 2026
2 checks passed
@fredericrous
fredericrous deleted the docs/code-rules-full-text branch October 24, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant