Skip to content

docs(review): F4b builds its brief with review-brief - #47

Merged
fredericrous merged 5 commits into
mainfrom
docs/review-brief-in-f4b
Oct 24, 2026
Merged

fredericrous merged 5 commits into
mainfrom
docs/review-brief-in-f4b

Conversation

@fredericrous

Copy link
Copy Markdown
Owner

Phase 2 of decisions docs/plans/2026-10-24-code-rules-reach-the-reviewer.md (ADR-0044), the skill and agent half. The code half is amont-agent 3.2.0 (#142, #143).

  • worktree-task F4b step 2 builds the implementation-review brief with amont-agent review-brief --plan <landed plan> instead of a hand-built list. The trigger for this programme was a reviewer whose hand-built brief carried rule statements only.
    • Exit 1 means pass --base. Exit 3 means aval failed: fix it, and do not hand-build the brief.
    • The one exception is a repository with no .adr.yaml (this one), which has no decided code rules.
  • Step 3 and the Delta put the <<<RULES sha=…>>> line in the reviewer's prompt. The push check reads that line and journals rules-current|missing|stale|unknown.
  • The implementation-review agent contract names the RULES line and the built brief, and says their absence in a repository with no corpus is not a defect.

Verification

Input Expected Observed
amont-agent --version after the tap upgrade 3.2.0 with both commands 3.2.0
review-brief for amont-agent#142 a brief its review bound to built and bound
review-brief in this repository exit 3 (no .adr.yaml) exit 3

chezmoi apply runs after the merge.

Implementation review

approve-with-changes, then approve-with-changes on the Delta. Every finding was fixed except one deliberate: the Delta step's no-corpus note ships with phase 4's edit of the same paragraph.

🤖 Generated with Claude Code

fredericrous and others added 5 commits October 24, 2026 23:25
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fredericrous
fredericrous merged commit ce5bf91 into main Oct 24, 2026
2 checks passed
@fredericrous
fredericrous deleted the docs/review-brief-in-f4b branch October 24, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant