Skip to content

docs(review): candidates in F4b and the contract - #49

Merged
fredericrous merged 4 commits into
mainfrom
docs/candidates-in-f4b
Oct 25, 2026
Merged

fredericrous merged 4 commits into
mainfrom
docs/candidates-in-f4b

Conversation

@fredericrous

Copy link
Copy Markdown
Owner

Phase 4 of decisions docs/plans/2026-10-24-code-rules-reach-the-reviewer.md (ADR-0044), the dotfiles part.

  • F4b's brief list now includes the <<<CANDIDATES …>>> block from amont-agent 3.3.0 and a ## Candidates section.
  • Step 3 and the Delta paste that block verbatim into the reviewer prompt after the RULES line. The push check reads the ids from the prompt, so the block is always carried. Step 3 asks for a Candidates: block when the block lists any id.
  • The no-corpus exception is removed: review-brief 3.3.0 builds that brief itself.
  • The implementation-review contract adds the Candidates: block, one ruling per listed id, either violation: or fine: <rule-body clause>. The 350-word cap leaves it out.

Verification

Input Expected Observed
amont-agent#144's reviewer given the inline block a ruling for every id 18/18, round 1 and delta
review-brief 3.3.0 here (no .adr.yaml) exit 0, no RULES line, a block exit 0, n=0

A deployed review read by the push check follows after chezmoi apply.

Implementation review

approve-with-changes, then approve on the Delta.

🤖 Generated with Claude Code

fredericrous and others added 4 commits October 25, 2026 12:10
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fredericrous
fredericrous merged commit 7ed96f0 into main Oct 25, 2026
2 checks passed
@fredericrous
fredericrous deleted the docs/candidates-in-f4b branch October 25, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant