Repository navigation
build(aot): enable PublishTrimmed and PublishAot now Discord.Net is gone #430
Description
Original prompts (live chat, while working on #423 / PR #428):
with the discord lib gone I'm guessing we're not too far from enabling PublishTrimmed and PublishAot ?
we should raie that as a follow on issue after this merges
that was "for after" not wait until it merges to raise
Goal
Enable PublishTrimmed and then PublishAot for src/BuildBot/BuildBot.csproj (currently both false). Work on this starts after PR #428 (Discord.Net replaced by a webhook) has merged.
Already in place
IsTrimmableandEnableTrimAnalyzerare on.JsonSerializerIsReflectionEnabledByDefault=false; JSON uses source-generated contexts.- Configuration binder and request delegate source generators are on; Mediator uses its source generator.
- Discord.Net (and its Newtonsoft.Json dependency) is removed by refactor(discord): replace Discord.Net bot login with a Discord webhook #428.
Likely work (to be confirmed by a trial publish)
- Start with
dotnet publish -r linux-x64 -p:PublishTrimmed=true, then-p:PublishAot=true, and fix every trim/AOT warning (warnings are errors). Serilog.Enrichers.Demystifier: reflection-based stack trace rewriting; probably remove (noteIlcGenerateStackTraceData=false).Microsoft.Extensions.Http.Polly(Polly v7) is not trim-annotated;Microsoft.Extensions.Http.Resilience(Polly v8) is the AOT-friendly option but is a new package needing owner sign-off.- Confirm
AWSSDK.CloudFormation4.x trim/AOT compatibility. - Check whether
System.Reactiveis still needed after refactor(discord): replace Discord.Net bot login with a Discord webhook #428'sDiscordMessageSenderBackgroundServicechange. - Dockerfile: an AOT build would use a
runtime-depsbase image; ICU is still needed (InvariantGlobalization=false).
A full implementation plan will be posted for approval before any work starts.
Activity
credfeto commentedon Oct 15, 2026
Priority set by the repository owner in live chat:
Highlabel applied.credfeto commentedon Oct 15, 2026
Note from PR #428 (owner, live chat: "q19 isn't that for when we're doing the trimming pr?"): after #428 rewrote
DiscordMessageSenderas aBackgroundService, no code insrcuses Rx any more.System.Reactive7.0.0 andSystem.Interactive.Async7.0.1 are still referenced fromsrc/BuildBot.ServiceModel/BuildBot.ServiceModel.csproj. Try removing both as part of this issue (keepSystem.Interactive.Asyncif the build shows itsSystem.Linqasync extensions are still used).credfeto commentedon Oct 16, 2026
Raised in the PR #428 code review (round 2): with Discord.Net gone, check whether anything still needs ICU. If nothing does, set
InvariantGlobalization=trueand switch from the chiseled-extra base image to the plain chiseled one (smaller image, less CVE surface). See #428 (comment).dnyw4l3n13 commentedon Oct 19, 2026
Implementation Plan
Files to change
src/BuildBot.ServiceModel/BuildBot.ServiceModel.csproj- removeSystem.Reactive(andSystem.Interactive.Asyncunless the build shows its async LINQ extensions are still used), per the refactor(discord): replace Discord.Net bot login with a Discord webhook #428 follow-up note.src/BuildBot/BuildBot.csproj- setPublishTrimmed=true, thenPublishAot=true; removeSerilog.Enrichers.Demystifier; setInvariantGlobalization=trueif nothing needs ICU; review/pruneTrimmerRootAssemblyentries.src/BuildBot/Helpers/ServerStartup.cs(and any Serilog setup) - drop the.Enrich.WithDemystifiedStackTraces()call.src/BuildBot.CloudFormation/*,src/BuildBot.Discord/*(and csproj files) - fix trim/AOT warnings found in a trial publish; Polly v7 (Microsoft.Extensions.Http.Polly) usage inDiscordSetup.cs/CloudformationSetup.csis the likely hotspot (see open questions).Dockerfile- if invariant globalization is viable, switch toruntime-deps:11.0-resolute-chiseledand update the comment. The base image staysruntime-deps, which suits AOT.*SetupTests.cs) andCHANGELOG.md- updated to match.Approach
Work in small, separately committed steps. (1) Remove unused Rx packages and confirm the build. (2) Run a trial
dotnet publish -r linux-x64 -p:PublishTrimmed=trueand fix every trim warning (warnings are errors). (3) Remove Demystifier. (4) Repeat with-p:PublishAot=trueand fix AOT warnings, confirm AWSSDK.CloudFormation 4.x is compatible. (5) Check whether ICU is needed; if not, setInvariantGlobalization=trueand use the plain chiseled image. (6) Turn the properties on in the csproj and smoke-test the published binary (startup,--health-check,/ping). Trial-publish results will be reported on the PR.Test strategy
Existing unit tests must pass with the coverage ratchet intact. Evidence of success:
dotnet publishforlinux-x64with PublishTrimmed and with PublishAot, both with zero warnings, and the published binary starting and answering--health-check//ping. Local container build if the sandbox allows it.Assumptions
Microsoft.Extensions.Http.Polly) may emit trim/AOT warnings; replacing it needs a new package.TrimmerRootAssemblyentries may be obsolete; they are removed only if the publish and smoke test prove it safe.Open questions
Microsoft.Extensions.Http.Resilience(Polly v8) as a new package? Otherwise I'd try to drop the Polly policies in favour of built-in handlers. Please approve the package or say which way to go.PublishTrimmedonly and leavePublishAot=falsewith a follow-up issue?build(aot): prototype native AOT publish on the arm64 runner
credfeto commentedon Oct 27, 2026
1 yes
2 yes
build: fix buildcheck configuration binding generator properties (#430)
build: remove unused System.Reactive and System.Interactive.Async pac…
build: remove Serilog.Enrichers.Demystifier (#430)
build: enable InvariantGlobalization and use plain chiseled runtime i…
build: publish BuildBot trimmed and as native AOT (#430)
docs: update changelog for trimmed AOT publish (#430)