Skip to content

[Dependencies] Updating Microsoft.VisualStudio.Threading.Analyzers (Code analysis) to 18.12.1 - #438

Draft
prpixie wants to merge 1 commit into
mainfrom
depends/update-microsoft.visualstudio.threading.analyzers/18.12.1
Draft

prpixie wants to merge 1 commit into
mainfrom
depends/update-microsoft.visualstudio.threading.analyzers/18.12.1

Conversation

@prpixie

@prpixie prpixie commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Description

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Removed no-longer used code

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • I have added tests to cover my changes.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.
  • No user-controlled or step-output value is string-interpolated directly into a run:/script: body (workflow or composite action); pass it via step-level env: and reference $VAR (bash) or process.env.VAR (github-script) instead.

@prpixie prpixie added the auto-pr Pull request created automatically label Oct 22, 2026
@prpixie prpixie added the auto-pr Pull request created automatically label Oct 22, 2026
@credfeto

credfeto commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Roslyn analyzer findings

✅ No findings.

@dnyw4l3n13 dnyw4l3n13 self-assigned this Oct 25, 2026
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Required check build-pre-release failed: the job reports SOURCE_PUSH_TOKEN is required but not set and AWS key needed for CloudFormation template validation is not set. This looks like missing secrets for the Dependabot-triggered run (an environment issue, not a code issue). Marking Blocked; secrets/CI config need a human.

@dnyw4l3n13 dnyw4l3n13 added Blocked Blocked by a dependency or external factor and removed Blocked Blocked by a dependency or external factor labels Oct 25, 2026
@dnyw4l3n13
dnyw4l3n13 force-pushed the depends/update-microsoft.visualstudio.threading.analyzers/18.12.1 branch from 2dd89af to 42a982a Compare October 25, 2026 20:47
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Rebased onto origin/main (conflicts in csproj/CHANGELOG resolved by keeping main and re-applying the Threading.Analyzers 18.12.1 bump); force-pushed. Next: CI, then review phases.

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Required check build-pre-release still fails after the rebase: the run reports 'AWS key needed for CloudFormation template validation is not set' (and SOURCE_PUSH_TOKEN unset). This is missing secrets for the bot-triggered run, not a code problem, so no code fix is possible from here. Marking Blocked: a human needs to provide the secrets or re-run the check with them.

@dnyw4l3n13 dnyw4l3n13 added the Blocked Blocked by a dependency or external factor label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-pr Pull request created automatically Blocked Blocked by a dependency or external factor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants