Skip to content

fix(workflows): stop concurrent pre-release builds racing for the same build number - #1065

Merged
dnyw4l3n13 merged 4 commits into
mainfrom
fix/1036-build-number-race
Oct 29, 2026
Merged

fix(workflows): stop concurrent pre-release builds racing for the same build number#1065
dnyw4l3n13 merged 4 commits into
mainfrom
fix/1036-build-number-race

Conversation

@dnyw4l3n13

@dnyw4l3n13 dnyw4l3n13 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Placeholder commit only. The fix for concurrent pre-release builds racing for the same build number will be implemented per the approved plan on #1036 in follow-up commits on this branch.

Closes #1036

@dnyw4l3n13 dnyw4l3n13 self-assigned this Oct 27, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent Medium Medium Priority labels Oct 27, 2026
@dnyw4l3n13

dnyw4l3n13 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Development: implemented the approved plan in e458d97 (new repo-wide serialised allocate-build-number job; build action takes an optional build-version input) and removed the placeholder in f85ff61. No CHANGELOG entry, as this is a template repo. Note: GitHub keeps only one pending run per concurrency group, as the plan's caveat said. Next: CI, then simplify.

@dnyw4l3n13

dnyw4l3n13 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Simplify clean - advancing to code review

@dnyw4l3n13

dnyw4l3n13 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Code review clean - advancing to security review

@dnyw4l3n13

dnyw4l3n13 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Security review clean, advancing to coverage check

@dnyw4l3n13

dnyw4l3n13 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Coverage ratchet skipped (non-code-only: workflow/action YAML only) - advancing to Human Review

@dnyw4l3n13
dnyw4l3n13 marked this pull request as ready for review October 27, 2026 22:11
@dnyw4l3n13
dnyw4l3n13 requested a review from a team as a code owner October 27, 2026 22:11
@dnyw4l3n13
dnyw4l3n13 enabled auto-merge October 27, 2026 22:11
@dnyw4l3n13

dnyw4l3n13 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Finalize: PR marked ready and auto-merge enabled.

@credfeto

credfeto commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Super-linter summary

Language Validation result
GITHUB_ACTIONS Pass ✅
YAML Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

credfeto
credfeto requested changes Oct 28, 2026
View reviewed changes
Comment thread .github/workflows/build-and-publish-pre-release.yml
@dnyw4l3n13
dnyw4l3n13 disabled auto-merge October 28, 2026 09:35
@dnyw4l3n13
dnyw4l3n13 marked this pull request as draft October 28, 2026 09:35
@dnyw4l3n13

dnyw4l3n13 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Simplify clean - advancing to code review (re-run after 302837a added the release allocate-build-number job)

@dnyw4l3n13

dnyw4l3n13 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Code review clean - advancing to security review

@dnyw4l3n13

dnyw4l3n13 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Security review clean, advancing to coverage check

@dnyw4l3n13

dnyw4l3n13 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Coverage ratchet skipped (non-code-only: workflow/action YAML only) - advancing to Human Review

@dnyw4l3n13
dnyw4l3n13 marked this pull request as ready for review October 28, 2026 09:57
@dnyw4l3n13
dnyw4l3n13 enabled auto-merge October 28, 2026 09:57
@dnyw4l3n13

dnyw4l3n13 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Finalize: all AI review phases clean on 302837a (credfeto's inline comment was addressed in that commit). PR marked ready and auto-merge enabled.

@dnyw4l3n13

dnyw4l3n13 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Status: credfeto's inline comment was already answered in 302837a (reply posted); required checks pass and auto-merge is enabled. The CHANGES_REQUESTED review remains until credfeto re-reviews or dismisses it; no further code changes needed.

@dnyw4l3n13 dnyw4l3n13 added the Blocked Blocked! label Oct 28, 2026
@dnyw4l3n13

dnyw4l3n13 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

This PR has an unaddressed review requesting changes and the automation's idle-invocation budget (5) is exhausted without further progress. Blocking this PR until a human investigates.

@credfeto credfeto removed the Blocked Blocked! label Oct 29, 2026
@dnyw4l3n13
chore: remove placeholder (#1036)
bbdce3d
@dnyw4l3n13
fix(ci): allocate release build number in serialised job (#1036)
5fc6531 
The release workflow uses the same shared .github/actions/build composite, so it raced on build number allocation just like pre-release. Add an allocate-build-number job sharing the repository-wide build-number concurrency group and pass its output into the build action.
@dnyw4l3n13

dnyw4l3n13 commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto origin/main (no conflicts) and force-pushed; CI will re-run. Auto-merge remains enabled and the PR is approved.

@dnyw4l3n13
dnyw4l3n13 force-pushed the fix/1036-build-number-race branch from 302837a to 5fc6531 Compare October 29, 2026 21:03
@dnyw4l3n13
dnyw4l3n13 merged commit 9345fc5 into main Oct 29, 2026
24 checks passed
@dnyw4l3n13
dnyw4l3n13 deleted the fix/1036-build-number-race branch October 29, 2026 21:21
credfeto added a commit that referenced this pull request Oct 30, 2026
@credfeto
fix(workflows): apply env conventions to allocate-build-number job
a914fb2 
Refs #1066

This brings the job added by the rebased build-number race fix (#1065) in line with the branch's conversions: the SOURCE_PUSH_TOKEN secret goes via step env; RUNNER_NAME/RUNNER_TEMP replace runner.name/runner.temp; the BUILD_VERSION self-map is dropped; a newline guard is added on the build-version output.

The race-fix logic is unchanged.
credfeto added a commit that referenced this pull request Oct 30, 2026
@credfeto
fix(actions): guard allocated build-version input before writing GITH…
666716d 
…UB_ENV

Refs #1066

Applies the branch's GITHUB_ENV newline guard and workflow-command strip to the step added by the rebased build-number race fix (#1065).

A check of all code main added found no other gaps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@credfeto credfeto credfeto approved these changes

Assignees

@dnyw4l3n13 dnyw4l3n13

Labels

AI-Work Work for an AI Agent Medium Medium Priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(workflows): stop concurrent pre-release builds racing for the same build number

2 participants

@dnyw4l3n13 @credfeto