Repository navigation
Run the wheel smoke test through uv; bump actions to Node 24 majors - #105
Merged
Merged
Conversation
The test-wheel job was the only Python step in the workflows that used actions/setup-python and pip. It now installs uv and runs the same script with uv run --with <built wheel>, so the wheel under test is the file from the build job and its dependencies come from PyPI. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Every job was annotated 'Node.js 20 is deprecated'. Each action moves to its newest major tag, and astral-sh/setup-uv is on one major (v7) in every workflow instead of v5 in lint and v6 elsewhere. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small workflow changes. No library, test, or dependency changes; the PyPI upload step and its credentials are untouched.
1. Wheel smoke test uses uv instead of pip
publish.yamltest-wheelwas the only Python step in the workflows that went throughactions/setup-python+pip install. It now installs uv and runs the same script withThe wheel under test is the file from the build job (passed by path, so never PyPI's copy of the same version); dependencies come from PyPI into a throwaway environment. The smoke script itself is unchanged.
Checked locally with that exact command (uv 0.13.7), both printing
wheel smoke test OK:uv build --wheel --python 3.11;wheels-linux-x86_64artifact of the lastpublishrun onmain(eight wheels indist/; the glob selects the single cp311 one).test-wheelalso runs on this pull request, so the check below exercises it in CI.2. Actions move to their Node 24 majors
Every job on
mainis annotated "Node.js 20 is deprecated". Each tag below was confirmed to exist and to declarenode24(or composite):actions/checkoutactions/setup-pythonactions/upload-artifactactions/download-artifactactions/cacheactions/upload-pages-artifactactions/deploy-pagesastral-sh/setup-uvpeter-evans/create-pull-requestastral-sh/setup-uvpublishes no major tag afterv7, sov7is the newest major pin.Not exercised by this pull request's checks, because they do not trigger on pull requests:
docs.yml(tags / manual),benchmark.yaml(aftertestsonmain),lock-upgrade.yaml(monthly / manual), and theReleasejob. The bumps there are version tags only, with no input changes. One behaviour to know about:actions/upload-pages-artifactsince v4 leaves dotfiles (e.g..buildinfo,.doctrees) out of the Pages artifact. A manualdocsrun on this branch builds without deploying if you want to check the build before merging.Local verification
uv lock --check: okuv run --locked --only-group lint ruff check .: All checks passeduv run --locked --only-group lint ruff format --check .: 144 files already formatteduv run --locked --group lint ty check --error-on-warning: All checks passeduv run pytest: 300 passed, 4 skipped, 1 xfailed; coverage 77.30% (floor 77%)🤖 Generated with Claude Code