Skip to content

Make feature create/delete undoable actions - #319

Open
TeunHuijben wants to merge 2 commits into
mainfrom
feature_actions
Open

TeunHuijben wants to merge 2 commits into
mainfrom
feature_actions

Conversation

@TeunHuijben

Copy link
Copy Markdown
Collaborator

Creating or deleting a feature (e.g. a group in napari-track-edit) used to bypass the action system, so it could not be undone, and deleting a group lost its values for good.

  • New basic actions AddFeature / DeleteFeature. Delete saves the column's values (only non-default ones, soft-deleted nodes included), so undo restores them.
  • New user actions UserAddFeature / UserDeleteFeature, which add the change to the undo history.
  • Node features only; edge features raise NotImplementedError.
  • Refused: adding an existing key; deleting a core key (time, position, track ids, mask, solution), an annotator-owned key, or a feature with derived features.
  • enable_features / disable_features are unchanged and not added to the history.

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.36364% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.41%. Comparing base (b6b76ca) to head (b40362a).

Files with missing lines Patch % Lines
src/funtracks/actions/add_delete_feature.py 95.45% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   94.36%   94.41%   +0.05%     
==========================================
  Files          64       66       +2     
  Lines        3883     3993     +110     
==========================================
+ Hits         3664     3770     +106     
- Misses        219      223       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant