Repository navigation
Launcher and in-game menu: Settings split into Video, Graphics, Audio and System - #114
Merged
Merged
Conversation
… and System The one Settings screen had grown long enough to need scrolling to find anything (the hardware renderer's two filter sets with their sliders on top of the window, the rate, the audio, the memory cards, the updates and Steam), in the launcher and more so in the in-game menu. It is now four screens, each its own entry in the navigation: - Video: window size, fullscreen, scaling, the rate (with the game's note), the in-game menu's size. - Graphics: the renderer, then the hardware renderer's resolution, 3D vertices and filter set(s). Under the software renderer these are shown greyed out under a line that says they need the GPU renderer, so the page keeps its shape; 3D vertices is greyed out at x1 too, saying it applies above x1 only. - Audio: mute (the place for audio settings to come). - System: memory cards, the host's own sections (the launcher's Updates and Steam: set_settings_extra is now set_system_extra), the settings file. The launcher's screens are Play, Disc, Video, Graphics, Audio, Controls, Mods, System; the menu's Game, Video, Graphics, Audio, Controls, Mods, System. <PREFIX>_PORT_MENU_SCREEN takes the new names, `settings` still opening Video. The settings file and the contract are unchanged. The self-test's pictures follow the pages (9-Graphics*, 18*-System-update*, 20*-System-steam*) and its screen loop takes the three new ones. hello_test.py --menu takes Graphics, the largest settings page, as its picture (and the GPU comparison's), and checks Video, Audio and System fit a 640x480 window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A game with scenes had its two filter sets one under the other, each with up to three sliders and a help line, so the
Graphics page still scrolled. They are now two tabs under the 3D vertices row, named by the scenes' labels (the first
letter capitalised: "Battles", "The field and the menus"); each tab holds the set's Filter row, sliders and help. The
set on screen in the in-game menu says so in its tab's name ("(on screen)", the tab's id stable as its name changes),
and a change of scene chooses its tab, so the menu opens on the set the player is looking at. A game without scenes
keeps its one Filter row. The game description's label is documented as the tab's name.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Settings screen had become one long scroll: the window, the rate, the renderer and its two filter sets with their sliders, then audio, memory cards, updates and Steam. It is now four screens, each its own entry in the launcher's navigation and in the in-game menu.
set_settings_extrais nowset_system_extra), and the settings file.<PREFIX>_PORT_MENU_SCREENtakes the new page names;settingsstill opens Video. The settings file and the contract are unchanged, so there is noPSXSTACK_APIbump.The tests follow the pages:
9-Graphics*,18*-System-update*,20*-System-steam*.hello_test.py --menunow takes its picture, and the GPU comparison's, on Graphics, the largest settings page. It also checks that Video, Audio and System fit a 640x480 window.The docs describe the new screens:
docs/LAUNCHER.md,docs/RUNTIME.md,launcher/README.md,README.mdandCLAUDE.md.Gates run
--self-teston Linux (offscreen): 600 of 600 checks passed (588 before; the screen loop's 3 new screens add 12).tests/hello_test.py --menu --gpupasses (lavapipe):--self-testunder Wine: 597 of 597 checks passed.tests/game_gen_test.pypasses (the schema's label descriptions now say "filter tab").🤖 Generated with Claude Code