Skip to content

Use CPack for uploading testing binaries for macOS static and MinGW - #2139

Draft
Rangi42 wants to merge 1 commit into
gbdev:masterfrom
Rangi42:more-cpack
Draft

Rangi42 wants to merge 1 commit into
gbdev:masterfrom
Rangi42:more-cpack

Conversation

@Rangi42

@Rangi42 Rangi42 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #2062.

We have previously talked about using CPack for more artifact uploads, instead of individually grouping/zipping them together.

One issue with doing so is that CPack would not include install.sh, which is needed for the release archives. That's why this PR only updates the testing binary archives.

Another issue is that CPack 3.x did not support CPACK_PACKAGE_FILE_NAME, and that's the version installed on some of GitHub's CI runners (including Ubuntu prior to the not-yet-available 26.04.1 LTS). This PR attempts to use the latest CPack from its maker Kitware's apt repository.

@Rangi42
Rangi42 requested a review from ISSOtm September 21, 2026 22:38
@Rangi42 Rangi42 added meta This isn't related to the tools directly: repo organization, maintainership... builds This affects the build process or release artifacts labels Sep 21, 2026
@ISSOtm ISSOtm added this to the 1.1.0 milestone Sep 21, 2026
@Rangi42
Rangi42 marked this pull request as draft September 22, 2026 02:43
@Rangi42
Rangi42 force-pushed the more-cpack branch 3 times, most recently from 93cf333 to 002bfd2 Compare October 14, 2026 22:02
@Rangi42

Rangi42 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

We can just wait until actions/runner-images#14748 upgrades ubuntu-latest (within the next month) to fix the MinGW builds.

@Rangi42 Rangi42 modified the milestones: 1.1.0, 1.0.5 Oct 15, 2026
@Rangi42
Rangi42 force-pushed the more-cpack branch 2 times, most recently from 069045b to c4da904 Compare October 17, 2026 16:23
@Rangi42 Rangi42 changed the title Use CPack for uploading testing binaries for macOS static and MinGW Use CPack for uploading macOS static binaries Oct 17, 2026
@Rangi42

Rangi42 commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor Author

Using CPack for the windows-mingw-build binaries is annoying because they need to be manually unzipped by windows-mingw-testing. Edit: ...but we have an "Extract binaries" step anyway to move the DLLs, so whatever.

@Rangi42 Rangi42 changed the title Use CPack for uploading macOS static binaries Use CPack for uploading testing binaries for macOS static and MinGW Oct 17, 2026
@Rangi42
Rangi42 marked this pull request as ready for review October 17, 2026 17:12
@Rangi42
Rangi42 marked this pull request as draft October 17, 2026 17:13
@Rangi42

Rangi42 commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

This is still a draft until actions/runner-images#14748 upgrades ubuntu-latest (within the next month), so we can get rid of our TODO.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds This affects the build process or release artifacts meta This isn't related to the tools directly: repo organization, maintainership...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants