Conversation
commit: |
✅ Testplane E2E run succeed
|
✅ Testplane browser-env run succeed
|
shadowusr
reviewed
Aug 24, 2026
|
|
||
| this._fail(); | ||
|
|
||
| signalHandler.emit(MasterEvents.EXIT, err); |
Contributor
Author
There was a problem hiding this comment.
Need for send event to reporter
shadowusr
reviewed
Aug 24, 2026
shadowusr
left a comment
shadowusr
left a comment
Member
There was a problem hiding this comment.
I'd wait with this one until issues in gemini-testing/html-reporter#800 are resolved.
sonic16x
force-pushed
the
fix-halt
branch
2 times, most recently
from
August 25, 2026 21:51
57ee3ab to
974af3d
Compare
sonic16x
commented
Aug 25, 2026
| @@ -0,0 +1,15 @@ | |||
| export const formatError = (err: Error): Error => { | |||
| const TRIM_MARKERS = ["Tests were stopped by the user"]; | |||
Contributor
Author
There was a problem hiding this comment.
Remove stack for some errors, now only for force stop
sonic16x
commented
Aug 25, 2026
| super(stateName, currImg, refImg); | ||
|
|
||
| this.message = `can not find reference image at ${this.refImg.path} for "${stateName}" state`; | ||
| this.stack = undefined; |
Contributor
Author
There was a problem hiding this comment.
Remove stack for no ref image error
added 2 commits
August 26, 2026 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add exit for test when halt and also add pass error to test in this case.