Pause hidden split-pane timeline queries - #4511
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Maximizing a split pane leaves sibling thread views mounted with enabled timeline query observers. An invalidation can refetch a sibling even while its pane is hidden. The direct reproduction and root-cause evidence are in the report.
What changed
The split layout passes pane visibility to the thread detail view. Hidden siblings disable their timeline observer and resume fetching when shown again. The pane and its local state stay mounted. No wire, CLI, or stored-data contract changed.
How you verified
origin/mainin two clean checkouts: expected one hidden-pane fetch, observed two.pnpm exec turbo run lint typecheck --filter=@bb/apppassed; lint reported 209 existing warnings and no errors.git diff --checkpassed. The patch changes 78 text lines (70 additions, 8 deletions) across three files and includes no binary changes.Fixes #4508