fix: gate login methods by server availability - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArcaneError.NotFoundas the Arcane 2.12+ compatibility fallback, and fail closed for other availability errorsNo libarcane-kotlin change is required; the existing typed
passkeys.loginAvailability()API and SDK error model cover this correction.Compatibility evidence
5d07cd0d3ba2925647687dafdc7b47e548ae2180, iOS8d13fdb5cd61a62b1d666e9e982a2670d86086c3, libarcane-kotlinb29695d547b78389ed7230b35cd133f7046b4b52, and Arcane5ac6d89756f80d22cf4f057865497cb9a8cf061d.available:false; the API 30 AVD showed password login only with no Passkey or OIDC action, including after force-stop/reopen. The public server was not mutated.available:false. The published image still served the availability route despite the pinned tag source omitting it, so the typed 404 path is covered deterministically.Tests
./gradlew :app:testDebugUnitTest :app:assembleDebug— 392 tests, 67 suites, zero failures/errors/skips./gradlew :app:lintDebug— no new findings (checked-in baseline unchanged)git diff --checkAutomated reviews are inactive; the staged diff received an independent focused self-review after the full validation run.