Skip to content

chore: fix flakey e2e tests - #4145

Merged
kmendell merged 1 commit into
mainfrom
chore_fix_flakey_e2e_tests
Sep 21, 2026
Merged

kmendell merged 1 commit into
mainfrom
chore_fix_flakey_e2e_tests

Conversation

@kmendell

@kmendell kmendell commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Checklist

  • This PR is not opened from my fork’s main branch
  • All new user-facing strings are translated via Paraglide (m.*())

What This PR Implements

Fixes:

Changes Made

Testing Done

AI Tool Used (if applicable)

Additional Context

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable regressions remain in the changes reviewed.

Summary

This PR makes the E2E suite more deterministic and diagnosable.

  • Runs browsers in an isolated, version-matched Playwright container on Linux.
  • Adds explicit cleanup, request synchronization, dialog readiness checks, and failure diagnostics.
  • Replaces timing-sensitive waits and adjusts CI artifact collection and test setup.
  • Fixes the previously reported dashboard fake-clock progression by explicitly advancing through the 10-second and 12-second transitions.

Reviews (2) · Last reviewed commit: "chore: fix flakey e2e tests"

@kmendell
kmendell marked this pull request as ready for review September 21, 2026 01:19
@kmendell
kmendell requested a review from a team September 21, 2026 01:19

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-21T20:57:57.851491Z 84ec79a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@graphite-app

graphite-app Bot commented Sep 21, 2026

Copy link
Copy Markdown

Graphite Automations

"Warn authors when publishing large PRs" took an action on this PR • (09/21/26)

1 teammate was notified to this PR based on Kyle Mendell's automation.

@arcane-github-automation

arcane-github-automation Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Container images for this PR have been built successfully!

  • Manager: ghcr.io/getarcaneapp/manager:pr-4145
  • Agent: ghcr.io/getarcaneapp/agent:pr-4145

Built from commit 84ec79a

@greptile-apps

This comment has been minimized.

@kmendell
kmendell marked this pull request as draft September 21, 2026 01:41
@kmendell
kmendell force-pushed the chore_fix_flakey_e2e_tests branch 5 times, most recently from 8ff540c to 7d18eda Compare September 21, 2026 20:32
@kmendell
kmendell force-pushed the chore_fix_flakey_e2e_tests branch from 7d18eda to 84ec79a Compare September 21, 2026 20:34
@kmendell
kmendell marked this pull request as ready for review September 21, 2026 20:52
@kmendell
kmendell merged commit 13accbe into main Sep 21, 2026
24 checks passed
@kmendell
kmendell deleted the chore_fix_flakey_e2e_tests branch September 21, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant