fix: environment-admin resource pages request globally protected data - #4151
Merged
kmendell merged 1 commit intoSep 22, 2026
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Container images for this PR have been built successfully!
Built from commit 3251e8a |
kmendell
force-pushed
the
fix_environment-admin_resource_pages_request_globally_protected_data
branch
from
September 22, 2026 00:13
1c71ba3 to
13d369c
Compare
kmendell
marked this pull request as ready for review
September 22, 2026 00:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Graphite Automations"Warn authors when publishing large PRs" took an action on this PR • (09/22/26)1 teammate was notified to this PR based on Kyle Mendell's automation. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
kmendell
force-pushed
the
fix_environment-admin_resource_pages_request_globally_protected_data
branch
from
September 22, 2026 01:04
13d369c to
bb5affb
Compare
kmendell
force-pushed
the
fix_environment-admin_resource_pages_request_globally_protected_data
branch
from
September 22, 2026 01:10
bb5affb to
3251e8a
Compare
kmendell
deleted the
fix_environment-admin_resource_pages_request_globally_protected_data
branch
September 22, 2026 01:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranchm.*())What This PR Implements
Fixes: #3911
Changes Made
Testing Done
AI Tool Used (if applicable)
Additional Context
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.The PR appears safe to merge; the changes since the previous review correctly address the outstanding encoder-error handling concern without introducing a new actionable issue.
Summary
This PR prevents environment-scoped administrators from requesting globally protected resources and moves environment-specific display data into authorized resource responses.
Reviews (3) · Last reviewed commit: "fix: environment-admin resource pages re..."