Repository navigation
ci: Run e2e tests on PRs with a local image registry - #346
Draft
andreiborza wants to merge 10 commits into
Draft
andreiborza wants to merge 10 commits into
andreiborza wants to merge 10 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andreiborza
commented
Oct 29, 2026
Comment on lines
-93
to
-94
| with: | ||
| fetch-depth: 0 |
Member
Author
There was a problem hiding this comment.
This was a leftover from when the step created a sentry release that tested set_commits and is no longer needed.
andreiborza
commented
Oct 29, 2026
Comment on lines
-14
to
-21
| env: | ||
| # Variables defined in the repository | ||
| SENTRY_ORG: ${{ vars.SENTRY_ORG }} | ||
| # For master, we have an environment variable that selects the action-release project | ||
| # instead of action-release-prs | ||
| # For other branches: https://sentry-ecosystem.sentry.io/releases/?project=4505075304693760 | ||
| # For master branch: https://sentry-ecosystem.sentry.io/releases/?project=6576594 | ||
| SENTRY_PROJECT: ${{ vars.SENTRY_PROJECT }} |
Member
Author
There was a problem hiding this comment.
This was needed for e2e tests and moved into the new e2e.yml workflow.
Member
Author
|
bugbot run |
# Conflicts: # dist/index.js
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 73c6eb2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
E2E tests now run on the image built in the same workflow run, from a local registry. Images go to ghcr.io only on push to master or release branches, after all e2e tests pass.
E2E / ....action.yml, so the branch tag hook is removed.Why
Fork PRs get a read-only token, so they cannot push an image and all e2e tests skip (for example #344). We also want to publish only images that passed the tests.