Repository navigation
fix(review-items): Let a person only dismiss a notice - #2563
Merged
Merged
Conversation
A notice has nothing to answer, and a plugin often closes it by itself, so Done and Dismiss meant the same thing. Remove Done from the Slack card and the review desk, and remove the complete action. Drop "or say why not" from the GitHub ready-to-merge notice, because a reply does not close a notice. Co-Authored-By: David Cramer <23610+dcramer@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
approved these changes
Nov 2, 2026
Contributor
|
3 screenshot changes — 3 changed · 0 added · 0 removed Review screenshots in Frameshift
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A notice has nothing to answer, and a plugin often closes it by itself, as GitHub's "Ready to merge" notice does when the PR merges. So Done and Dismiss meant the same thing, and Done read like it would merge the PR.
Notices now offer only Dismiss, on the Slack card and on the review desk. The
completeaction and its "marked … done" message are gone, because nothing else used them. Items that a person already closed as done still render as before.The GitHub ready-to-merge notice also drops "or say why not". A reply in the thread does not close a notice, so that line asked for something that has no effect.
Notice cards that are already posted keep their Done button until their next update, which comes when the item changes or closes. Until then, a click on that button does nothing.
via @dcramer.
--
View Session [Sentry]