Repository navigation
build(release): Prepare releases with craft's own action - #165
Merged
Merged
Conversation
action-prepare-release titles the publish issue with the raw version input, so an "auto" release was requested as "scm-platform@auto" (getsentry/publish#10017) even though craft had prepared 2.0.0, and publish would have run `craft publish auto`. The action now lives in the craft repo and titles the issue with the version craft resolved. Its inputs are the same, and 3.0.0's breaking changes don't apply here: we don't set a changelog path, and preReleaseCommand bumps the version, so craft's own bumping (which now fails when it finds nothing) never runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks
3 tasks done
vaind
added a commit
that referenced
this pull request
Oct 26, 2026
## Problem The README's release steps date from before #163–#165. They tell you to pick a bump type, say the version comes from `pyproject.toml`, and name `getsentry/action-prepare-release`. Following them skips craft's `auto` versioning, so a breaking PR could ship as a minor release. ## Approach Update the "Releasing a New Version" steps to match the current workflow: - run with the default `auto`, and how PR titles map to major/minor/patch, with the explicit bump types kept as overrides; - what the workflow produces: the `release/<version>` branch, the `CHANGELOG.md` section, and the publish issue to check; - what happens after **accepted**: CI gate, PyPI/internal index/GitHub release, release branch merged into `main`; - PR titles must follow conventional commits, with `!` for breaking changes. The manual `getsentry/pypi` step, adding `python_versions = >=3.13` to its PR, is removed. Since getsentry/pypi#2639, that repository's build skips Python versions excluded by a package's `Requires-Python`. The 2.0.0 PR (getsentry/pypi#2669) merged without the line, and its build skipped 3.11 and 3.12 on its own. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #164, releases default to
version: auto. Craft resolved it correctly and preparedrelease/2.0.0. But the pinnedgetsentry/action-prepare-releasev1.6.6 titles the publish issue with the raw input, so it requestedgetsentry/scm-platform@auto(getsentry/publish#10017). The publish workflow takes the version from that title, so approving the issue would runcraft publish auto.Approach
Switch to the same action, which now lives in the craft repo (
getsentry/craft), pinned to 3.0.0. It titles the issue with the version craft resolved (RESOLVED_VERSIONin itsaction.yml). The inputs we pass (version,force,GITHUB_TOKEN) are unchanged. sentry-dotnet already uses this action.None of 3.0.0's breaking changes apply here:
preparefails when automatic bumping finds nothing: ourpreReleaseCommanddoes the bump, so craft's automatic bumping never runs.Checked with actionlint. Before the next release run, retract getsentry/publish#10017 and delete the
release/2.0.0branch.🤖 Generated with Claude Code