Skip to content

fix(sentry-admin): Run the container once for --help - #4537

Closed
oioki wants to merge 1 commit into
masterfrom
alextarasov/sentry-admin-help-single-invocation
Closed

oioki wants to merge 1 commit into
masterfrom
alextarasov/sentry-admin-help-single-invocation

Conversation

@oioki

@oioki oioki commented Sep 29, 2026

Copy link
Copy Markdown
Member

rename_sentry_bin_in_help_output already receives the help output as $1, but it ran the container a second time with its own arguments, so the whole help text was passed as the command. The old bash entrypoint echoed that argument in its exec error, so the help still showed up by accident. The sentry image's new Python entrypoint (getsentry/sentry#125892) doesn't, so ./sentry-admin.sh --help on :nightly prints only a traceback and test_sentry_admin fails. This also makes --help start one container instead of two.

Unblocks #4536, and self-hosted master's scheduled tests now that :nightly includes #125892.

rename_sentry_bin_in_help_output already receives the help output as $1, but it ran the container again with its own arguments, passing the whole help text as the command. The bash entrypoint echoed that argument in its error message, so the help text still appeared by accident; the Python entrypoint in the current sentry image doesn't, so --help printed only a traceback.
@oioki

oioki commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

Folded into #4536.

@oioki oioki closed this Sep 29, 2026
@oioki
oioki deleted the alextarasov/sentry-admin-help-single-invocation branch September 29, 2026 20:26
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Coverage Results 📊

✅ 17 passed | ⏭️ 5 skipped | Total: 22 | Pass Rate: 77.27% | Execution Time: 8m 0s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 50%).
Project statement coverage is 82.44% (unchanged from base (85ef848) to head (25748a6)).

Coverage diff
@@            Coverage Diff             @@
##        master     #4537       +/-##
==========================================
  Coverage    82.44%    82.44%        —%
==========================================
  Files            5         5         —
  Tracked lines       336       336         —
  Branches         0         0         —
==========================================
  Hits           277       277         —
  Misses          59        59         —
  Partials         0         0         —

Generated by Coverage Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant