test(integration): Check the enhance-image marker with python instead of bash - #4541
Merged
Merged
Conversation
… of bash The last two bash invocations inside sentry containers in the integration tests.
BYK
approved these changes
Sep 30, 2026
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 9m 32s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 50%). Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #4541 +/-##
==========================================
Coverage 95.54% 95.54% —%
==========================================
Files 5 5 —
Tracked lines 336 336 —
Branches 0 0 —
==========================================
Hits 321 321 —
Misses 15 15 —
Partials 0 0 —Generated by Coverage Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_customizationschecked for/created-by-enhance-imagewithbash -c 'if [ ! -e … ]; then exit 1; fi'in thewebandsentry-cleanupcontainers. Usepython -c "import os; assert os.path.exists(…)"instead, like theimport ldapchecks next to it. These were the lastbashinvocations inside sentry containers in the integration tests.Prep for moving the sentry image to a distroless base, which has no bash.