Conversation
Use only exec-form RUNs in sentry/Dockerfile and move the enhance-image.sh, requirements.txt and /etc/ssl/certs steps into customize_image.py, so the image also builds on a sentry image without a shell (the distroless variant). enhance-image.sh still runs on images that have a shell and fails the build with a clear message on those that don't.
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 10m 48s All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 50%). Coverage diff@@ Coverage Diff @@
## master #4543 +/-##
==========================================
Coverage 95.54% 95.54% —%
==========================================
Files 5 5 —
Tracked lines 336 336 —
Branches 0 0 —
==========================================
Hits 321 321 —
Misses 15 15 —
Partials 0 0 —Generated by Coverage Action |
Member
Yeah this clearly is a breaking change and I'd say we need community feedback before making a move. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge: up for a closer look.
sentry/Dockerfilenow uses only exec-formRUNs, sosentry-self-hosted-localalso builds on a sentry image without a shell, such asghcr.io/getsentry/sentry:nightly-distroless. Theenhance-image.sh,requirements.txtand/etc/ssl/certssteps move intosentry/customize_image.py, unchanged in behavior on the regular image.On an image without a shell,
requirements.txtstill works, but a non-emptyenhance-image.shfails the build with a clear message, since it's a shell script (and usually runsapt-get).customize_image.pylives in./sentrybecause that's the build context, so it also shows up in the/etc/sentrymount at runtime.Part of making self-hosted run on the distroless sentry image by changing only
SENTRY_IMAGE.