fix(healthcheck): Let Docker enforce HEALTHCHECK_TIMEOUT in check_http.py - #4546
Merged
Merged
Conversation
…p.py check_http.py gave up after a hardcoded 2 seconds, so it effectively overrode HEALTHCHECK_TIMEOUT (1m30s by default). Drop the script's own timeout and let Docker kill a check that runs past HEALTHCHECK_TIMEOUT, like it did for the previous bash check.
Coverage Results 📊✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 9m 46s All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 50%). Generated by Coverage Action |
oioki
marked this pull request as ready for review
October 1, 2026 17:38
aminvakil
approved these changes
Oct 1, 2026
vgrozdanic
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_http.py(#4539) gave up after a hardcoded 2 seconds, which effectively overrodeHEALTHCHECK_TIMEOUTfrom.env(1m30sby default) forwebandsnuba-api. Drop the script's own timeout so Docker kills a check that runs pastHEALTHCHECK_TIMEOUT, as it did for the previous bash check. Fast failures (connection refused, HTTP errors, missingok) still get the script's one-line messages; a hung check shows Docker'sHealth check exceeded timeout (…).Follow-up to #4539 (comment).