feat(attributes): Deprecate sentry.device.class in favor of device.class - #604
Draft
buenaflor wants to merge 2 commits into
Draft
feat(attributes): Deprecate sentry.device.class in favor of device.class#604buenaflor wants to merge 2 commits into
buenaflor wants to merge 2 commits into
Conversation
Add sentry.device.class as a deprecated alias so ingest can backfill
device.class. Document that Relay writes stringified numeric class codes
("1"/"2"/"3"), not the labels low/medium/high.
Co-authored-by: Cursor <cursoragent@cursor.com>
Treat the stored stringified class codes as the well-known values. Keep low/medium/high as the product display mapping. Co-authored-by: Cursor <cursoragent@cursor.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
sentry.device.classas a deprecated alias ofdevice.class(_status: backfill) so ingest can copy the value onto the stable name.device.classstays a string. The brief still describes the labelslow/medium/high. Examples and additional context document what Relay actually writes today: stringified numeric class codes"1"/"2"/"3", not those labels.PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)If an attribute was deprecated: