feat(names): Add browser.* span name and description rules - #607
Merged
Lms24 merged 1 commit intoSep 2, 2026
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Names
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Lms24
marked this pull request as ready for review
September 1, 2026 13:59
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
September 1, 2026 13:59
nsdeschenes
approved these changes
Sep 2, 2026
Names are static per phase, since all ten navigation timing spans come from one PerformanceNavigationTiming entry and would otherwise repeat the document URL. Descriptions keep the URL via `url.full`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-names-browser-spans
branch
from
September 2, 2026 10:38
1a03527 to
fec442e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds name and description rules for the
browser.*navigation timing and paint ops. Names are static per phase, descriptions keep the document URL viaurl.full.All ten navigation timing spans are built from a single
PerformanceNavigationTimingentry, sourl.domainwould be identical on every sibling span and add nothing to the name. I therefore opted to omit them. But happy to bring back the domain or something else low card. if reviewers prefer.Depends on
browser.paint.typefrom #606