Skip to content

log4j spring boot 4 autoinstrumentation - #5403

Open
lbloder wants to merge 13 commits into
mainfrom
feat/log4j-autoinstrumentation
Open

log4j spring boot 4 autoinstrumentation#5403
lbloder wants to merge 13 commits into
mainfrom
feat/log4j-autoinstrumentation

Conversation

@lbloder

@lbloder lbloder commented May 11, 2026

Copy link
Copy Markdown
Collaborator

📜 Description

💡 Motivation and Context

resolves: #5035

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@sentry

sentry Bot commented May 11, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.54.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 315.90 ms 367.98 ms 52.08 ms
Size 0 B 0 B 0 B

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a416a65 333.78 ms 410.37 ms 76.59 ms
2195398 319.02 ms 342.38 ms 23.36 ms
62b579c 349.26 ms 426.26 ms 77.00 ms
bbc35bb 324.88 ms 425.73 ms 100.85 ms
e59e22a 374.68 ms 442.14 ms 67.46 ms
806307f 357.85 ms 424.64 ms 66.79 ms
62b579c 312.88 ms 361.57 ms 48.70 ms
8687935 332.52 ms 362.23 ms 29.71 ms
1edbdfa 364.77 ms 450.29 ms 85.52 ms
2195398 322.52 ms 361.91 ms 39.39 ms

App size

Revision Plain With Sentry Diff
a416a65 1.58 MiB 2.12 MiB 555.26 KiB
2195398 0 B 0 B 0 B
62b579c 0 B 0 B 0 B
bbc35bb 1.58 MiB 2.12 MiB 553.01 KiB
e59e22a 1.58 MiB 2.20 MiB 635.34 KiB
806307f 1.58 MiB 2.10 MiB 533.42 KiB
62b579c 0 B 0 B 0 B
8687935 1.58 MiB 2.19 MiB 619.17 KiB
1edbdfa 1.58 MiB 2.20 MiB 635.34 KiB
2195398 0 B 0 B 0 B

@lbloder

lbloder commented May 12, 2026

Copy link
Copy Markdown
Collaborator Author

@sentry review

@lbloder

lbloder commented May 12, 2026

Copy link
Copy Markdown
Collaborator Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7d76aa5. Configure here.

@lbloder
lbloder marked this pull request as ready for review May 26, 2026 06:35
Comment thread sentry-samples/sentry-samples-spring-boot-4/build.gradle.kts Outdated
@lbloder

lbloder commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

@adinauer should we add a separate spring-boot-log4j sample for e2e tets?

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just needs to be opt-in for now, to not break manual setups on upgrade. Separate sample + E2E tests sounds good

Comment thread CHANGELOG.md Outdated
Co-authored-by: Alexander Dinauer <adinauer@users.noreply.github.com>
…move log4j dependencies in spring-boot-4 sample

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4362c07. Configure here.

@lbloder

lbloder commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

@adinauer added the sample and e2e tests

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spring Boot support for Log4j2

2 participants