fix(scopes): apply withScope data to events in globalHubMode - #6004
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
markushi
marked this pull request as ready for review
August 26, 2026 10:05
markushi
requested review from
0xadam-brown,
adinauer,
romtsn and
runningcode
as code owners
August 26, 2026 10:05
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
markushi
added
the
deep-dive
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…-hub-mode # Conflicts: # CHANGELOG.md
adinauer
approved these changes
Aug 28, 2026
adinauer
left a comment
adinauer
left a comment
Member
There was a problem hiding this comment.
LGTM!
l we could add new tests for global hub mode to SentryContextTest. We still have a TODO there from the hubs scopes merge.
…-hub-mode # Conflicts: # CHANGELOG.md
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
Author
Done in 0e8f818. Two tests added, and the
Test-only, no production change. |
…ests The transaction is finished asynchronously, after the HTTP response has been returned, so verifying the transport call right after the exchange races with the send and fails intermittently. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
buenaflor
pushed a commit
that referenced
this pull request
Aug 28, 2026
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Sentry.withScopeforks the current scope and makes it current, butSentry.getCurrentScopesshort-circuited torootScopeswhenglobalHubModewas enabled, so the fork was never read back. Everything set inside the callback was silently dropped.Honour scopes that were explicitly made current, as long as they descend from the current
rootScopes. Implicit forking stays suppressed.pushScopeandpopScoperemain no-ops, since they are unbalanced.💡 Motivation and Context
globalHubModeis on by default on Android, so this affected all Android users since 8.0.0.💚 How did you test it?
Unit tests in
SentryTest.kt, run forglobalHubModebothtrueandfalse. Verified they fail without the fix.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Hybrid SDKs relying on
withScopebeing a no-op underglobalHubModeshould be made aware.🤖 Generated with Claude Code