ref(core): Mark NoOp stubs as @ApiStatus.Internal - #6016
ref(core): Mark NoOp stubs as @ApiStatus.Internal#6016sentry-junior[bot] wants to merge 1 commit into
Conversation
These no-op implementations are SDK plumbing, not public API. Marking them internal now documents the contract so they can be relocated in a future major without implying customer support. Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
📲 Install BuildsAndroid
|
There was a problem hiding this comment.
Thanks for this @runningcode 👍
I'm definitely okay with our making any implementations internal whose interface is also internal (~ half of those here, as my clanker tells me).
What's the thinking around making implementations internal whose interface is – and after this PR will remain – public (eg, making NoOpScope internal but leaving IScope public)? Do we plan to make those interfaces internal in a follow-on? Otherwise, I'm not sure I see how the win on our end would beat out the inconvenience to others (but I may be overlooking something).
|
I did it this way because I thought this would be the least controversial change so that way we can start moving classes out of the top level I think I am not following your point, why does it matter that the interface needs to be internal as well for |
📜 Description
Mark remaining public NoOp/stub implementations with class-level
@ApiStatus.Internal.💡 Motivation and Context
Marking them internal now makes the public contract honest and sets up a later major to relocate them under
io.sentry.internal.*without implying they were supported surface.💚 How did you test it?
No api changes with apidump
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog
Requested by no.
--
View Junior Session [Sentry]