Skip to content

chore(solidstart): Refresh SolidStart test versions - #23451

Merged
andreiborza merged 1 commit into
getsentry:developfrom
birkskyum:chore/refresh-solidstart-versions
Aug 24, 2026
Merged

chore(solidstart): Refresh SolidStart test versions#23451
andreiborza merged 1 commit into
getsentry:developfrom
birkskyum:chore/refresh-solidstart-versions

Conversation

@birkskyum

@birkskyum birkskyum commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Refresh the SolidStart versions exercised by the SDK while preserving legacy v1 coverage:

  • move the retained package development target and root lockfile from SolidStart 1.2.1 to the final v1 release, 1.3.2
  • move the existing Node 24 SolidStart 2 E2E fixture from 2.0.0 to 2.0.2

SolidStart 1 is deprecated and is retained here only for legacy compatibility testing, but it's really not wise to stay on that version. SolidStart 2 is the supported and recommended version and has dedicated Vite/Nitro integration and E2E coverage in @sentry/solidstart from #23090.

Keep the package development target on the latest SolidStart 1 release and update the dedicated SolidStart 2 E2E fixture to the latest patch.

Co-Authored-By: OpenAI Codex <codex@openai.com>
@birkskyum
birkskyum marked this pull request as ready for review August 19, 2026 13:17
@birkskyum
birkskyum requested a review from a team as a code owner August 19, 2026 13:17
@birkskyum
birkskyum requested review from mydea and s1gr1d and removed request for a team August 19, 2026 13:17
@mydea
mydea requested a review from andreiborza August 19, 2026 13:19
@github-actions

Copy link
Copy Markdown
Contributor

👋 @mydea, @s1gr1d, @andreiborza — Please review this PR when you get a chance!

@andreiborza andreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @birkskyum, thanks for updating this. LGTM

@andreiborza
andreiborza merged commit 0d5cd79 into getsentry:develop Aug 24, 2026
1142 of 1182 checks passed
andreiborza added a commit that referenced this pull request Aug 24, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #23451

Co-authored-by: andreiborza <168741329+andreiborza@users.noreply.github.com>
JPeer264 pushed a commit that referenced this pull request Aug 25, 2026
Refresh the SolidStart versions exercised by the SDK while preserving
legacy v1 coverage:

- move the retained package development target and root lockfile from
SolidStart 1.2.1 to the final v1 release, 1.3.2
- move the existing Node 24 SolidStart 2 E2E fixture from 2.0.0 to 2.0.2

SolidStart 1 is deprecated and is retained here only for legacy
compatibility testing, but it's really not wise to stay on that version.
SolidStart 2 is the supported and recommended version and has dedicated
Vite/Nitro integration and E2E coverage in `@sentry/solidstart` from
#23090.

Co-authored-by: OpenAI Codex <codex@openai.com>
JPeer264 pushed a commit that referenced this pull request Aug 25, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #23451

Co-authored-by: andreiborza <168741329+andreiborza@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants