feat(vue): Register a route provider backed by the Vue router matcher - #23553
Closed
logaretm wants to merge 1 commit into
Closed
feat(vue): Register a route provider backed by the Vue router matcher#23553logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
5 tasks
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 24, 2026 20:11
af59909 to
737c9cf
Compare
logaretm
force-pushed
the
awad/route-provider-vue
branch
from
August 24, 2026 20:11
3232b67 to
09293e3
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 24, 2026 20:17
737c9cf to
5d8e20b
Compare
logaretm
force-pushed
the
awad/route-provider-vue
branch
2 times, most recently
from
August 24, 2026 20:27
2270fa1 to
0329f44
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 24, 2026 20:52
5d8e20b to
464c7d0
Compare
logaretm
force-pushed
the
awad/route-provider-vue
branch
from
August 24, 2026 20:52
0329f44 to
b97883e
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 24, 2026 20:57
464c7d0 to
1eb7910
Compare
logaretm
force-pushed
the
awad/route-provider-vue
branch
from
August 24, 2026 20:57
b97883e to
03f9074
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 31, 2026 16:39
1eb7910 to
21288e6
Compare
logaretm
force-pushed
the
awad/route-provider-vue
branch
from
August 31, 2026 16:39
03f9074 to
76f3c07
Compare
Labels routes through the same helper the navigation instrumentation uses, so a
route resolved by the provider can't disagree with the one on the span.
Handles both resolve shapes: Vue Router 3 returns `{ route }`, Vue Router 4+
returns the route itself.
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 31, 2026 17:05
21288e6 to
fec1a68
Compare
logaretm
force-pushed
the
awad/route-provider-vue
branch
from
August 31, 2026 17:05
76f3c07 to
beda5be
Compare
logaretm
changed the base branch from
awad/route-provider-nextjs
to
awad/route-provider-react-router
August 31, 2026 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider backed by Vue Router's own matcher.
The provider always returns the matched path, never
route.name, even underrouteLabel: 'name'. Callers seturl.templatefrom the resolved string and a route name is not a template, so the provider has to stay a path. The navigation instrumentation still names the span after the route name when the user asked for it.Matcher-backed rather than fed from
beforeEach, becausebeforeEachis registered after the pageload span is already created. Resolving against the router means Vue is one of the SDKs that can name its pageload span at creation once the consumers land, instead of renaming it after the fact.Vue Router 3 resolves to
{ route }while 4+ returns the route directly, so the provider discriminates onmatched.Part of #23556