fix(bundler-plugins): Stamp debug IDs onto emitted source maps when disable-upload is set - #23754
Draft
msonnb wants to merge 1 commit into
Draft
fix(bundler-plugins): Stamp debug IDs onto emitted source maps when disable-upload is set#23754msonnb wants to merge 1 commit into
disable-upload is set#23754msonnb wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0637f26. Configure here.
…disable-upload` is set
msonnb
force-pushed
the
ms/bundler-plugins-disable-upload-fix
branch
from
August 31, 2026 11:45
0637f26 to
532bb7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sourcemaps.disable: 'disable-upload'now stamps the bundle's debug ID into the emitted.js.map. The JS bundle is left untouched, so subresource integrity hashes computed during the build stay valid. Stamping happens in the bundler's asset pipeline (processAssets/generateBundle) where one exists; esbuild has none, so its maps are rewritten on disk inonEnd.Why
Debug-ID stamping lived only inside the upload routine, which wrote it to temp copies of the artifacts — so
disable-uploadskipped exactly the half a later manualsentry sourcemap upload/sentry-cli sourcemaps uploaddepends on, and every artifact ended up withdebugId: null. The option's documented purpose ("manually upload sourcemaps at a later point in time") was therefore not achievable, and thesentry sourcemap inject/sentry-cli sourcemaps injectworkaround generates a different ID and rewrites the bundle.Fixes getsentry/sentry-javascript-bundler-plugins#949
Fixes getsentry/sentry-javascript-bundler-plugins#603