Skip to content

ref(express)!: Export a single ExpressIntegrationOptions type - #23763

Open
s1gr1d wants to merge 1 commit into
developfrom
sig/handle-error-type
Open

ref(express)!: Export a single ExpressIntegrationOptions type#23763
s1gr1d wants to merge 1 commit into
developfrom
sig/handle-error-type

Conversation

@s1gr1d

@s1gr1d s1gr1d commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

First merge this: #23732

Raised by @isaacs in this comment: https://github.com/getsentry/sentry-javascript/pull/23732/changes#r3890547157

ExpressIntegrationOptions was exported publicly from two places under the same name. The one from @sentry/core is deprecated and has no shouldHandleError.
The one from @sentry/server-utils has it but was unreachable, because @sentry/node re-exports neither. TypeScript users had no way to type a shouldHandleError callback for expressIntegration().

@s1gr1d
s1gr1d requested review from a team as code owners August 31, 2026 11:52
@s1gr1d
s1gr1d requested review from isaacs and mydea and removed request for a team August 31, 2026 11:52
@s1gr1d s1gr1d changed the title test(express): Error handler tests ref(express)!: Export a single ExpressIntegrationOptions type Aug 31, 2026
@s1gr1d
s1gr1d changed the base branch from develop to sig/express-handleError August 31, 2026 11:53
This was referenced Aug 31, 2026
Merged
Merged
@s1gr1d
s1gr1d force-pushed the sig/handle-error-type branch from 163fc2f to 46630d2 Compare August 31, 2026 14:59
Base automatically changed from sig/express-handleError to develop August 31, 2026 14:59
@s1gr1d
s1gr1d force-pushed the sig/handle-error-type branch from 46630d2 to 5821de7 Compare August 31, 2026 14:59
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.56 kB -4.27% -1.27 kB 🔽
@sentry/browser - with treeshaking flags 26.92 kB -3.95% -1.11 kB 🔽
@sentry/browser (incl. Tracing) 48.75 kB +3.19% +1.51 kB 🔺
@sentry/browser (incl. Tracing + Span Streaming) 48.76 kB +3.16% +1.49 kB 🔺
@sentry/browser (incl. Tracing, Profiling) 51.68 kB -0.62% -321 B 🔽
@sentry/browser (incl. Tracing, Replay) 88.23 kB +1.89% +1.64 kB 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.63 kB +2.14% +1.62 kB 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 92.93 kB +1.81% +1.65 kB 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 105.85 kB +1.83% +1.9 kB 🔺
@sentry/browser (incl. Feedback) 46.05 kB -2.31% -1.09 kB 🔽
@sentry/browser (incl. sendFeedback) 33.62 kB -3.02% -1.04 kB 🔽
@sentry/browser (incl. FeedbackAsync) 38.73 kB -2.64% -1.05 kB 🔽
@sentry/browser (incl. Metrics) 29.51 kB -4.53% -1.4 kB 🔽
@sentry/browser (incl. Logs) 29.8 kB -4.32% -1.34 kB 🔽
@sentry/browser (incl. Metrics & Logs) 30.43 kB -4.35% -1.38 kB 🔽
@sentry/react 30.3 kB -4.19% -1.32 kB 🔽
@sentry/react (incl. Tracing) 50.94 kB +2.9% +1.43 kB 🔺
@sentry/vue 35.73 kB +2.31% +806 B 🔺
@sentry/vue (incl. Tracing) 51.02 kB +3.61% +1.77 kB 🔺
@sentry/svelte 28.59 kB -4.25% -1.27 kB 🔽
CDN Bundle 30.35 kB -4.79% -1.52 kB 🔽
CDN Bundle (incl. Tracing) 49.38 kB +3.88% +1.84 kB 🔺
CDN Bundle (incl. Logs, Metrics) 32.58 kB -2.5% -834 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 51.25 kB +4.72% +2.31 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 73.17 kB +0.59% +425 B 🔺
CDN Bundle (incl. Tracing, Replay) 86.86 kB +1.97% +1.68 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.73 kB +2.58% +2.23 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 92.8 kB +1.97% +1.79 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.64 kB +2.53% +2.33 kB 🔺
CDN Bundle - uncompressed 89.95 kB -4.94% -4.67 kB 🔽
CDN Bundle (incl. Tracing) - uncompressed 147.2 kB +3.58% +5.08 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.24 kB -3.02% -3 kB 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.89 kB +4.65% +6.79 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.41 kB +0.66% +1.47 kB 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 266.69 kB +2.04% +5.32 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.37 kB +2.65% +7.03 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 280.4 kB +1.94% +5.32 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 286.06 kB +2.52% +7.03 kB 🔺
@sentry/nextjs (client) 53.56 kB +2.84% +1.48 kB 🔺
@sentry/sveltekit (client) 49.19 kB +3.11% +1.48 kB 🔺
@sentry/core/server 65.67 kB +0.22% +144 B 🔺
@sentry/core/browser 51.86 kB -0.04% -20 B 🔽
@sentry/node 123.77 kB +2.94% +3.53 kB 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 85.53 kB added added
@sentry/node - without tracing 88.03 kB +5.19% +4.34 kB 🔺
@sentry/aws-serverless 96.42 kB +4.41% +4.07 kB 🔺
@sentry/cloudflare (withSentry) - minified 201.04 kB -8.06% -17.61 kB 🔽
@sentry/cloudflare (withSentry) 500.26 kB -7.17% -38.59 kB 🔽
@sentry/browser - with treeshaking flags tracing without tracing 26.82 kB added added
@sentry/node - without channel injection 103.18 kB added added

View base workflow run

s1gr1d added a commit that referenced this pull request Aug 31, 2026
@s1gr1d
feat(v10/node): Deprecate shouldHandleError on `setupExpressErrorHa…
bea4d38 
…ndler` and `setupFasitfyErrorHandler` (#23734)

Express:
- #23732
- #23464
- #23763
Fastify:
- #23460
- #23464
- #23411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes
@isaacs isaacs Awaiting requested review from isaacs isaacs was automatically assigned from getsentry/team-javascript-sdks-server

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s1gr1d @mydea