feat(core): Isolate throwing user callbacks instead of capturing them as events - #23770
Draft
msonnb wants to merge 1 commit into
Draft
feat(core): Isolate throwing user callbacks instead of capturing them as events#23770msonnb wants to merge 1 commit into
msonnb wants to merge 1 commit into
Conversation
…m as events Wraps `beforeSend`, `beforeSendTransaction`, event processors, `tracesSampler`, `beforeBreadcrumb`, `beforeSendLog` and `beforeSendMetric` in `safeCallback`. A throwing or rejecting callback now drops the event/breadcrumb/log/metric (with a client report where one exists) instead of escaping into the calling code or being captured as an `internal` error event. `tracesSampler` falls back to the parent sampling decision, then `tracesSampleRate`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
msonnb
changed the title
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5336fc6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps
beforeSend,beforeSendTransaction, event processors,tracesSampler,beforeBreadcrumb,beforeSendLogandbeforeSendMetricin thesafeCallbackhelper from #23760. A throwing or rejecting callback no longer escapes into the calling code and is no longer captured as aninternalerror event; the event/breadcrumb/log/metric is dropped, a client report is recorded where a category exists, and the error is logged in debug mode.part of #23755