feat(browser)!: Rename bfcacheIntegration to bfcacheMetricsIntegration - #23776
Merged
Conversation
…tion` bfcache is going to show up in more than one place (navigation spans, Web Vitals attribution), so the integration is named after what it actually does rather than the feature area.
Contributor
size-limit report 📦
|
logaretm
marked this pull request as ready for review
August 31, 2026 16:18
logaretm
requested review from
Lms24 and
msonnb
and removed request for
a team
August 31, 2026 16:18
Lms24
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
bfcacheIntegrationtobfcacheMetricsIntegration.bfcache is going to be involved in a few areas beyond this integration, navigation spans representing a bfcache restore, and Web Vitals bfcache attribution.
Keeping the one-word name would imply the integration covers all of that, when it only emits the bfcache metrics.
The integration name string also changes (
Bfcache->BfcacheMetrics) since it is user-visible and would otherwise collide with a future bfcache tracing integration.