test(e2e): Port React Router v5 and v6 E2E apps to span streaming - #23841
Open
andreiborza wants to merge 1 commit into
Open
test(e2e): Port React Router v5 and v6 E2E apps to span streaming#23841andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
andreiborza
marked this pull request as ready for review
September 1, 2026 14:17
Contributor
size-limit report 📦
|
Lms24
approved these changes
Sep 1, 2026
| 'sentry.origin': { value: 'auto.navigation.react.reactrouter_v6', type: 'string' }, | ||
| 'sentry.segment.name.source': { value: 'route', type: 'string' }, | ||
| 'url.template': { value: '/bar/:barId', type: 'string' }, | ||
| 'url.path': { value: '/bar/456', type: 'string' }, |
Member
There was a problem hiding this comment.
super-l: should we also assert against url.full here? Just noticed we do so below but feel free to skip
Member
Author
There was a problem hiding this comment.
Added it, the original test omitted it there but there is no reason to.
chargome
approved these changes
Sep 1, 2026
andreiborza
force-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 1, 2026 16:51
d87c67b to
b0f464f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b0f464f. Configure here.
andreiborza
force-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 2, 2026 08:23
b0f464f to
37956c8
Compare
Removes the `traceLifecycle: 'static'` pin from `react-router-5`, `react-router-6`, `react-router-6-use-routes` and `react-router-6-descendant-routes`, and rewrites their specs against streamed span v2. The `react-router-6` SSE spec needed more than a helper swap: streamed `http.client` names carry only the domain, so the request is matched on `url.full`, and the abort error is read off the console because spans carry no breadcrumbs. All three SSE tests load the same route, so each one also pins its lookup to a pageload span that started after it navigated.
andreiborza
force-pushed
the
ab/js-3482/react-router-v5-v6
branch
from
September 2, 2026 08:46
37956c8 to
b24c46c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-router-5,react-router-6,react-router-6-use-routesandreact-router-6-descendant-routesto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. The SSE spec needed more than a helper swap: a streamed
http.clientspan carries only the domain in its name, so the request is matched onurl.full, and the abort error is read off the console because spans carry no breadcrumbs.Part of #23798