test(e2e): Port React Router data router E2E apps to span streaming - #23842
Open
andreiborza wants to merge 2 commits into
Open
test(e2e): Port React Router data router E2E apps to span streaming#23842andreiborza wants to merge 2 commits into
andreiborza wants to merge 2 commits into
Conversation
Contributor
size-limit report 📦
|
chargome
approved these changes
Sep 1, 2026
andreiborza
marked this pull request as ready for review
September 1, 2026 14:53
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
from
September 1, 2026 14:56
450d0d3 to
361c467
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Removes the `traceLifecycle: 'static'` pin from `react-create-browser-router`, `react-create-hash-router` and `react-create-memory-router`, and rewrites their specs against streamed span v2. Two attribute groups moved under streaming and the assertions follow them: the navigator data is now `device.memory.estimated_capacity`, `device.processor_count` and `network.connection.effective_type`, and the pageload timings are `browser.performance.*`. LCP is streamed as its own `ui.webvital.lcp` span once the page hides, so it is no longer asserted on the pageload span.
Streamed spans always carry the common sdk/release/environment and segment attributes on top of what a test names, and a pageload span also carries the web vitals, so the exhaustive attribute match could not hold. Scope the lazy-route resource spans to their own segment's trace, so the initial pageload's bundle scripts cannot satisfy the count.
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
from
September 1, 2026 16:51
361c467 to
a0463ab
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a0463ab. Configure here.
| const childSpans = spans.filter( | ||
| span => !span.is_segment && !(span.attributes['url.full']?.value as string | undefined)?.includes('favicon'), | ||
| ); | ||
| expect(childSpans).toEqual([]); |
There was a problem hiding this comment.
Navigation tests pick the wrong span
Medium Severity
These navigation tests violate the flake-prone wait convention and the relaxed-assertion rule for payloads that must exclude children. waitForStreamedSpans returns one envelope, then spans.find takes the first is_segment span without checking sentry.op. Pageload and navigation can share an envelope, so the wrong segment is selected or leftover children fail the empty-child check; if they flush separately the empty-child assertion never sees the rest of the trace.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit a0463ab. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-create-browser-router,react-create-hash-routerandreact-create-memory-routerto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. Two attribute groups moved and the assertions follow them: the navigator data is now
device.memory.estimated_capacity,device.processor_countandnetwork.connection.effective_type, and the pageload timings arebrowser.performance.*. LCP is streamed as its ownui.webvital.lcpspan once the page hides, so it is no longer asserted on the pageload span.Part of #23798