test(e2e): Port the astro-6 E2E app to span streaming - #24077
Merged
Conversation
Contributor
size-limit report 📦
|
Drops the `traceLifecycle: 'static'` pin and rewrites the specs to assert on streamed spans.
andreiborza
force-pushed
the
ab/e2e-astro-6-streaming
branch
from
September 4, 2026 12:07
1e240b2 to
1d9a94b
Compare
andreiborza
marked this pull request as ready for review
September 4, 2026 14:01
Lms24
approved these changes
Sep 4, 2026
Comment on lines
+34
to
+36
| 'sentry.op': { value: 'pageload', type: 'string' }, | ||
| 'sentry.origin': { value: 'auto.pageload.astro', type: 'string' }, | ||
| 'sentry.segment.name.source': { value: 'route', type: 'string' }, |
Member
There was a problem hiding this comment.
looks like we lost a couple of attribute assertions here. intentional?
Member
Author
| expect(clientPageloadSpan.attributes).toMatchObject({ | ||
| 'sentry.op': { value: 'pageload', type: 'string' }, | ||
| 'sentry.origin': { value: 'auto.pageload.astro', type: 'string' }, | ||
| 'sentry.segment.name.source': { value: 'route', type: 'string' }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
traceLifecycle: 'static'pin from the client and server configs, and rewrites the transaction specs as streamed span specs. Assertions on children of a segment now accumulate the trace withcollectStreamedSpans.Two names change under span streaming, and the specs follow the value into the attributes instead: the outgoing
http.clientspan is named after the domain (GET localhost), and the browserresource.linkspan for a server island is too.Why
Span streaming is the default, so the default E2E suite should exercise it. Static coverage lives in the new
astro-7-staticapp (#24075).Ref: #23809