test(e2e): Port the nestjs-fastify E2E app to span streaming - #24100
Draft
chargome wants to merge 1 commit into
Draft
test(e2e): Port the nestjs-fastify E2E app to span streaming#24100chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
Removes the `traceLifecycle: 'static'` pin and rewrites the specs against streamed spans. Fastify names both its request span and its middie route-handler span after the route, so the spec tells them apart by attribute rather than by name. Ref: #23801 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b15c217. Configure here.
andreiborza
reviewed
Sep 4, 2026
Comment on lines
+10
to
+12
| function waitForSegmentSpan(name: string): Promise<unknown> { | ||
| return waitForStreamedSpan(APP_NAME, span => span.is_segment && span.name === name); | ||
| } |
Member
There was a problem hiding this comment.
We keep repeating this helper, can we just pull it up and use it across our e2e suote?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
traceLifecycle: 'static'pin and rewrites the specs against streamed spans.Fastify names both its request span and its middie route-handler span after the route, so the spec tells them apart by attribute rather than by name.
Ref: #23801
🤖 Generated with Claude Code